Merge lp:~jelmer/brz/init-repo-weave-fmt into lp:brz

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/init-repo-weave-fmt
Merge into: lp:brz
Diff against target: 42 lines (+15/-1)
2 files modified
breezy/builtins.py (+6/-1)
breezy/plugins/weave_fmt/test_repository.py (+9/-0)
To merge this branch: bzr merge lp:~jelmer/brz/init-repo-weave-fmt
Reviewer Review Type Date Requested Status
Martin Packman Approve
Review via email: mp+342438@code.launchpad.net

Commit message

Don't explicitly specify repository format to fixed component bzrdirs (like weave).

Description of the change

Don't explicitly specify repository format to fixed component bzrdirs (like weave).

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Okay.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/builtins.py'
2--- breezy/builtins.py 2018-03-25 00:39:16 +0000
3+++ breezy/builtins.py 2018-03-30 03:43:52 +0000
4@@ -2279,12 +2279,17 @@
5
6 to_transport = transport.get_transport(location)
7
8+ if format.fixed_components:
9+ repo_format_name = None
10+ else:
11+ repo_format_name = format.repository_format.get_format_string()
12+
13 (repo, newdir, require_stacking, repository_policy) = (
14 format.initialize_on_transport_ex(to_transport,
15 create_prefix=True, make_working_trees=not no_trees,
16 shared_repo=True, force_new_repo=True,
17 use_existing_dir=True,
18- repo_format_name=format.repository_format.get_format_string()))
19+ repo_format_name=repo_format_name))
20 if not is_quiet():
21 from .info import show_bzrdir_info
22 show_bzrdir_info(newdir, verbose=0, outfile=self.outf)
23
24=== modified file 'breezy/plugins/weave_fmt/test_repository.py'
25--- breezy/plugins/weave_fmt/test_repository.py 2018-02-18 15:21:06 +0000
26+++ breezy/plugins/weave_fmt/test_repository.py 2018-03-30 03:43:52 +0000
27@@ -252,6 +252,15 @@
28
29 class TestInterWeaveRepo(TestCaseWithTransport):
30
31+ def test_make_repository(self):
32+ out, err = self.run_bzr("init-repository --format=weave a")
33+ self.assertEqual(out,
34+"""Standalone tree (format: weave)
35+Location:
36+ branch root: a
37+""")
38+ self.assertEqual(err, "")
39+
40 def test_is_compatible_and_registered(self):
41 # InterWeaveRepo is compatible when either side
42 # is a format 5/6/7 branch

Subscribers

People subscribed via source and target branches