Breezy

Merge lp:~jelmer/brz/increase-time-window into lp:brz

  1. increase-time-window
  2. Merge into trunk
Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/increase-time-window
Merge into: lp:brz
Diff against target: 12 lines (+1/-1)
1 file modified
breezy/tests/per_tree/test_get_file_mtime.py (+1/-1)
To merge this branch: bzr merge lp:~jelmer/brz/increase-time-window
Reviewer Review Type Date Requested Status
Martin Packman Approve
Review via email: mp+359026@code.launchpad.net

Commit message

Use 10 minute (rather than 5 second) window when checking mtime behaviour.

Description of the change

Use 10 minute (rather than 5 second) window when checking mtime behaviour.

This fixes a timeout on riscv.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

As discussed, this seems fair enough (though the time it takes to run the testing for debian is nuts).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/tests/per_tree/test_get_file_mtime.py'
2--- breezy/tests/per_tree/test_get_file_mtime.py 2018-11-11 04:08:32 +0000
3+++ breezy/tests/per_tree/test_get_file_mtime.py 2018-11-20 01:15:29 +0000
4@@ -40,7 +40,7 @@
5 # file, working trees return the on-disk time.
6 mtime_file_id = tree.get_file_mtime('one')
7 self.assertIsInstance(mtime_file_id, (float, int))
8- self.assertTrue(now - 5 < mtime_file_id < now + 5,
9+ self.assertTrue(now - 10 * 60 < mtime_file_id < now + 10 + 60,
10 'now: %f, mtime_file_id: %f' % (now, mtime_file_id))
11 mtime_path = tree.get_file_mtime('one')
12 self.assertEqual(mtime_file_id, mtime_path)

Subscribers

People subscribed via source and target branches