Merge lp:~jelmer/brz/hoster-comment into lp:brz/3.1

Proposed by Jelmer Vernooij
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/hoster-comment
Merge into: lp:brz/3.1
Diff against target: 12 lines (+2/-0)
1 file modified
breezy/plugins/gitlab/hoster.py (+2/-0)
To merge this branch: bzr merge lp:~jelmer/brz/hoster-comment
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+388531@code.launchpad.net

Commit message

Raise PermissionDenied when posting a comments results in a 403.

Description of the change

Raise PermissionDenied when posting a comments results in a 403.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/plugins/gitlab/hoster.py'
2--- breezy/plugins/gitlab/hoster.py 2020-08-02 03:22:34 +0000
3+++ breezy/plugins/gitlab/hoster.py 2020-08-02 18:39:33 +0000
4@@ -476,6 +476,8 @@
5 if response.status == 201:
6 json.loads(response.data)
7 return
8+ if response.status == 403:
9+ raise errors.PermissionDenied(response.text)
10 _unexpected_status(path, response)
11
12 def _create_mergerequest(

Subscribers

People subscribed via source and target branches