Merge lp:~jelmer/brz/fix-spurious into lp:brz

Proposed by Jelmer Vernooij on 2018-08-20
Status: Merged
Approved by: Jelmer Vernooij on 2018-08-20
Approved revision: 7068
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/fix-spurious
Merge into: lp:brz
Diff against target: 11 lines (+0/-1)
1 file modified
breezy/tests/test_smart_transport.py (+0/-1)
To merge this branch: bzr merge lp:~jelmer/brz/fix-spurious
Reviewer Review Type Date Requested Status
Martin Packman 2018-08-20 Approve on 2018-08-20
Review via email: mp+353457@code.launchpad.net

Commit message

Fix a spuriously failing test.

Description of the change

Fix a spurious test.

Sometimes we don't have to wait for the client to disconnect, and thus no
message gets printed.

To post a comment you must log in.
Martin Packman (gz) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/tests/test_smart_transport.py'
2--- breezy/tests/test_smart_transport.py 2018-07-27 01:17:23 +0000
3+++ breezy/tests/test_smart_transport.py 2018-08-20 21:38:16 +0000
4@@ -1467,7 +1467,6 @@
5 self.assertThat(log, DocTestMatches("""\
6 INFO Requested to stop gracefully
7 ... Stopping SmartServerSocketStreamMedium(client=('127.0.0.1', ...
8- INFO Waiting for 1 client(s) to finish
9 """, flags=doctest.ELLIPSIS|doctest.REPORT_UDIFF))
10
11 def test_stop_gracefully_tells_handlers_to_stop(self):

Subscribers

People subscribed via source and target branches