Merge lp:~jelmer/brz/fix-git-subpath into lp:brz

[Jelmer Vernooij]

Properly interpret error message about subpath on github.

Properly interpret error message about subpath on github.

[Jelmer Vernooij (jelmer)]

review: Approve

=== modified file 'breezy/git/remote.py'
--- breezy/git/remote.py	2019-07-26 08:21:20 +0000
+++ breezy/git/remote.py	2019-08-11 15:31:23 +0000
@@ -211,6 +211,9 @@
         return PermissionDenied(url, message)
     if message.endswith(' does not appear to be a git repository'):
         return NotBranchError(url, message)
+    if re.match('(.+) is not a valid repository name',
+                message.splitlines()[0]):
+        return NotBranchError(url, message)
     m = re.match(r'Permission to ([^ ]+) denied to ([^ ]+)\.', message)
     if m:
         return PermissionDenied(m.group(1), 'denied to %s' % m.group(2))

=== modified file 'breezy/git/tests/test_remote.py'
--- breezy/git/tests/test_remote.py	2019-07-15 23:40:33 +0000
+++ breezy/git/tests/test_remote.py	2019-08-11 15:31:23 +0000
@@ -125,6 +125,14 @@
         self.assertEqual(e.path, 'porridge/gaduhistory.git')
         self.assertEqual(e.extra, ': denied to jelmer')
 
+    def test_invalid_repo_name(self):
+        e = parse_git_error(
+            "url",
+            """Gregwar/fatcat/tree/debian is not a valid repository name
+Email [e-mail] for help
+""")
+        self.assertIsInstance(e, NotBranchError)
+
 
 class TestRemoteGitBranchFormat(TestCase):