Merge lp:~jelmer/brz/dont-match into lp:brz

Proposed by Jelmer Vernooij on 2017-06-22
Status: Merged
Approved by: Jelmer Vernooij on 2017-06-22
Approved revision: 6717
Merge reported by: The Breezy Bot
Merged at revision: not available
Proposed branch: lp:~jelmer/brz/dont-match
Merge into: lp:brz
Diff against target: 12 lines (+1/-1)
1 file modified
breezy/log.py (+1/-1)
To merge this branch: bzr merge lp:~jelmer/brz/dont-match
Reviewer Review Type Date Requested Status
Martin Packman 2017-06-22 Approve on 2017-06-22
Review via email: mp+326121@code.launchpad.net

This proposal supersedes a proposal from 2017-06-22.

Commit message

Don't apply matcher logic unless --match is specified in ``bzr log``.

Description of the change

Quick performance fix for ``bzr log`` - don't run regexes over all logs that are printed *unless* one of the --match options is specified.

To post a comment you must log in.
Martin Packman (gz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/log.py'
2--- breezy/log.py 2017-06-05 20:48:31 +0000
3+++ breezy/log.py 2017-06-22 01:57:07 +0000
4@@ -861,7 +861,7 @@
5 :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
6 delta).
7 """
8- if match is None:
9+ if not match:
10 return log_rev_iterator
11 searchRE = [(k, [re.compile(x, re.IGNORECASE) for x in v])
12 for k, v in match.items()]

Subscribers

People subscribed via source and target branches