Merge lp:~jelmer/brz/bug842695-log-dir into lp:brz

Proposed by Jelmer Vernooij
Status: Merged
Merged at revision: 6838
Proposed branch: lp:~jelmer/brz/bug842695-log-dir
Merge into: lp:brz
Diff against target: 41 lines (+31/-0)
1 file modified
breezy/tests/test_log.py (+31/-0)
To merge this branch: bzr merge lp:~jelmer/brz/bug842695-log-dir
Reviewer Review Type Date Requested Status
Martin Packman Approve
Review via email: mp+334652@code.launchpad.net

Description of the change

Add test for bug #842694; incorrect revisions being included in "brz log --include-merges".

Based on lp:~gagern/bzr/bug842695-log-dir

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Okay.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'breezy/tests/test_log.py'
2--- breezy/tests/test_log.py 2017-11-16 00:39:04 +0000
3+++ breezy/tests/test_log.py 2017-12-04 00:45:47 +0000
4@@ -284,6 +284,37 @@
5 self.assertEqual('add file1 and file2', logentry.rev.message)
6 self.checkDelta(logentry.delta, added=['file1', 'file2'])
7
8+ def test_bug_842695_log_restricted_to_dir(self):
9+ # Comments here indicate revision numbers in trunk # VVVVV
10+ trunk = self.make_branch_and_tree('this')
11+ trunk.commit('initial trunk') # 1
12+ adder = trunk.controldir.sprout('adder').open_workingtree()
13+ merger = trunk.controldir.sprout('merger').open_workingtree()
14+ self.build_tree_contents([
15+ ('adder/dir/',),
16+ ('adder/dir/file', 'foo'),
17+ ])
18+ adder.add(['dir', 'dir/file'])
19+ adder.commit('added dir') # 1.1.1
20+ trunk.merge_from_branch(adder.branch)
21+ trunk.commit('merged adder into trunk') # 2
22+ merger.merge_from_branch(trunk.branch)
23+ merger.commit('merged trunk into merger') # 1.2.1
24+ # Commits are processed in increments of 200 revisions, so
25+ # make sure the two merges into trunk are in different chunks.
26+ for i in xrange(200):
27+ trunk.commit('intermediate commit %d' % i) # 3-202
28+ trunk.merge_from_branch(merger.branch)
29+ trunk.commit('merged merger into trunk') # 203
30+ file_id = trunk.path2id('dir')
31+ lf = LogCatcher()
32+ lf.supports_merge_revisions = True
33+ log.show_log(trunk.branch, lf, file_id)
34+ try:
35+ self.assertEqual(['2', '1.1.1'], [r.revno for r in lf.revisions])
36+ except AssertionError:
37+ raise tests.KnownFailure("bug #842695")
38+
39
40 class TestFormatSignatureValidity(tests.TestCaseWithTransport):
41 class UTFLoopbackGPGStrategy(gpg.LoopbackGPGStrategy):

Subscribers

People subscribed via source and target branches