Merge lp:~jeffmarcom/opencompute/symlink-bug-fix-1230365 into lp:opencompute/checkbox
Proposed by
Jeff Marcom
Status: | Merged |
---|---|
Approved by: | Jeff Lane |
Approved revision: | 2153 |
Merged at revision: | 2155 |
Proposed branch: | lp:~jeffmarcom/opencompute/symlink-bug-fix-1230365 |
Merge into: | lp:opencompute/checkbox |
Diff against target: |
75 lines (+13/-9) 4 files modified
bin/checkbox-ocp-cli (+1/-1) bin/checkbox-ocp-gtk (+4/-0) bin/checkbox-ocp-qt (+4/-8) bin/checkbox-ocp-urwid (+4/-0) |
To merge this branch: | bzr merge lp:~jeffmarcom/opencompute/symlink-bug-fix-1230365 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeff Lane | Approve | ||
Review via email: mp+187560@code.launchpad.net |
Commit message
Added a simple check to bypass the symlink creation in an Ubuntu based release.
Description of the change
The symlink only needs to be created in a Centos environment,
This adds a simple check to bypass the symlink creation in an Ubuntu based release.
To post a comment you must log in.
Not sure if you care about this or not (functionally it works either way) but
grep -q "Ubuntu" /etc/issue d/configs ]
if [ $? -ne 0 ] && [ ! -L /etc/checkbox.
Can be expressed: d/configs ]
if ( grep -q "Ubuntu" /etc/issue ) && [ ! -L /etc/checkbox.
As long as you're fine with it as is, I'll approve it, but I thought I'd at least make the comment