Checkbox

Merge lp:~jeffmarcom/checkbox/accelerometer_test_fix into lp:checkbox

  1. accelerometer_test_fix
  2. Merge into trunk
Proposed by Jeff Marcom on 2013-02-28
Status: Merged
Approved by: Daniel Manrique on 2013-02-28
Approved revision: 1956
Merged at revision: 1956
Proposed branch: lp:~jeffmarcom/checkbox/accelerometer_test_fix
Merge into: lp:checkbox
Diff against target: 27 lines (+5/-1)
2 files modified
debian/changelog (+4/-1)
jobs/input.txt.in (+1/-0)
To merge this branch: bzr merge lp:~jeffmarcom/checkbox/accelerometer_test_fix
Reviewer Review Type Date Requested Status
Daniel Manrique 2013-02-28 Approve on 2013-02-28
Review via email: mp+151089@code.launchpad.net

Description of the change

Added simple check for accelerometer test to only run on hardware with hdaps and hp_accel modules loaded and working.

Now the job will be skipped on machines that do not have any accelerometer hardware at all.

To post a comment you must log in.
Daniel Manrique (roadmr) wrote :

Awesome, thanks!

review: Approve
Ara Pulido (ara) wrote :

What happens with systems with accelerometer but no working drivers?

Daniel Manrique (roadmr) wrote :

This case would require a "please check your computer's specifications. Is the computer supposed to have an accelerometer?" test. We do something similar with the multi-touch tests. The logic can be a bit crazy :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-02-27 22:27:39 +0000
3+++ debian/changelog 2013-02-28 20:26:21 +0000
4@@ -8,7 +8,10 @@
5 [ Daniel Manrique ]
6 * Added pipefail option to a few jobs using ansi_parser (LP: #1131598)
7
8- -- Brendan Donegan <brendan.donegan@canonical.com> Mon, 18 Feb 2013 14:35:27 +0000
9+ [ Jeff Marcom ]
10+ * jobs/input.txt.in Added job requirement for accelerometer test (LP: #1135832)
11+
12+ -- Jeff Marcom <jeff.marcom@ubuntu.com> Mon, 18 Feb 2013 14:35:27 +0000
13
14 checkbox (0.15.3) raring; urgency=low
15
16
17=== modified file 'jobs/input.txt.in'
18--- jobs/input.txt.in 2013-01-31 23:30:18 +0000
19+++ jobs/input.txt.in 2013-02-28 20:26:21 +0000
20@@ -44,6 +44,7 @@
21 plugin: user-interact
22 name: input/accelerometer
23 user: root
24+requires: module.name in ['hdaps', 'hp_accel']
25 command: accelerometer_test -m
26 _description:
27 PURPOSE:

Subscribers

People subscribed via source and target branches