Merge lp:~jeffmarcom/checkbox-certification/multi-nic-tests into lp:checkbox-certification

Proposed by Jeff Marcom
Status: Rejected
Rejected by: Jeff Lane 
Proposed branch: lp:~jeffmarcom/checkbox-certification/multi-nic-tests
Merge into: lp:checkbox-certification
Diff against target: 39 lines (+2/-5)
3 files modified
data/server-cert.whitelist (+0/-2)
data/server-selftest.whitelist (+0/-2)
debian/changelog (+2/-1)
To merge this branch: bzr merge lp:~jeffmarcom/checkbox-certification/multi-nic-tests
Reviewer Review Type Date Requested Status
Jeff Lane  Disapprove
Review via email: mp+138201@code.launchpad.net

Commit message

Removed multi-nic tests from server whitelists by Jeff Marcom

Description of the change

Currently multi nic tests run while both interfaces are connected. The usual scenario is that both interfaces exist on the same subnet. While doing a ping flood on one interface it's common to see a false degradation in regards to speed and packet reception. This is due to how the linux kernel routes traffic. It's been shown that this test rarely if ever passes due to the methodology in place. The flaky nature of this particular test means that it needs to be removed from the test suite.

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Per discussing with Jeff and Brendan, I am rejecting this. The plan we have is to leave this in place until we have a working replacement to avoid holes in test coverage.

review: Disapprove

Unmerged revisions

558. By Jeff Marcom

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/server-cert.whitelist'
2--- data/server-cert.whitelist 2012-10-16 17:02:38 +0000
3+++ data/server-cert.whitelist 2012-12-05 15:15:39 +0000
4@@ -78,8 +78,6 @@
5 __networking__
6 networking/detect
7 networking/bandwidth
8-networking/multi_nic
9-networking/multi_nic_eth\d
10 networking/ntp
11 __optical__
12 optical/detect
13
14=== modified file 'data/server-selftest.whitelist'
15--- data/server-selftest.whitelist 2012-10-16 17:02:38 +0000
16+++ data/server-selftest.whitelist 2012-12-05 15:15:39 +0000
17@@ -74,8 +74,6 @@
18 __networking__
19 networking/detect
20 networking/bandwidth
21-networking/multi_nic
22-networking/multi_nic_eth\d
23 __optical__
24 optical/detect
25 optical/read-automated
26
27=== modified file 'debian/changelog'
28--- debian/changelog 2012-12-04 00:22:15 +0000
29+++ debian/changelog 2012-12-05 15:15:39 +0000
30@@ -5,8 +5,9 @@
31 website, and modified certify_prompt to also fire the new required event
32 for this to work. Added preliminary new certification website submission
33 to checkbox-certification-submit.
34+ * Removed multi-nic tests from server whitelists
35
36- -- Daniel Manrique <roadmr@ubuntu.com> Fri, 16 Nov 2012 12:31:20 -0500
37+ -- Jeff Marcom <jeff.marcom@ubuntu.com> Fri, 16 Nov 2012 12:31:20 -0500
38
39 checkbox-certification (0.14) quantal; urgency=low
40

Subscribers

People subscribed via source and target branches