Merge lp:~jeffery9/oemedical/oemedical into lp:oemedical

Proposed by jeffery chen fan
Status: Work in progress
Proposed branch: lp:~jeffery9/oemedical/oemedical
Merge into: lp:oemedical
Diff against target: 27 lines (+2/-2)
2 files modified
oemedical/__openerp__.py (+1/-1)
oemedical/oemedical_lab/oemedical_lab.py (+1/-1)
To merge this branch: bzr merge lp:~jeffery9/oemedical/oemedical
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp Needs Resubmitting
Yannick Vaucher @ Camptocamp code review, no tests Needs Fixing
Pedro Manuel Baeza Needs Fixing
Review via email: mp+194051@code.launchpad.net

Description of the change

fix xml data loading order and wrong import

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Jeffery, thank you very much for the MP.

Please remove import line instead commenting it, to keep the code clean.

BTW, the rest seems OK.

Regards.

review: Needs Fixing
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Same as Pedro, please remove the import line.

Otherwise as we talk about import you could also improve

from osv import fields, osv

by repacing it with

from openerp.osv import fields, osv

review: Needs Fixing (code review, no tests)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

I set this one WIP as there was no activity from author

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

Hello,

The management of the project has moved to Github: https://github.com/OCA/vertical-medical

Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how to proceed.

Thanks for contributing to the project

review: Needs Resubmitting

Unmerged revisions

109. By jeffery chen fan

wrong import mx module

108. By jeffery chen fan

change the xml loading order
for lab depends on the oemedical_menu.xml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'oemedical/__openerp__.py'
2--- oemedical/__openerp__.py 2013-09-23 18:29:30 +0000
3+++ oemedical/__openerp__.py 2013-11-06 02:46:12 +0000
4@@ -139,9 +139,9 @@
5 'oemedical_genetics/oemedical_disease_gene_view.xml',
6 'oemedical_genetics/data/disease_genes.xml',
7 'oemedical_socioeconomics/oemedical_socioeconomics_view.xml',
8- 'oemedical_lab/oemedical_lab_view.xml',
9 'security/ir.model.access.csv',
10 'oemedical_menu.xml',
11+ 'oemedical_lab/oemedical_lab_view.xml',
12 ],
13 "demo": [
14
15
16=== modified file 'oemedical/oemedical_lab/oemedical_lab.py'
17--- oemedical/oemedical_lab/oemedical_lab.py 2013-09-23 18:55:14 +0000
18+++ oemedical/oemedical_lab/oemedical_lab.py 2013-11-06 02:46:12 +0000
19@@ -17,7 +17,7 @@
20
21
22 import time
23-from mx import DateTime
24+#from mx import DateTime
25 import datetime
26 from osv import fields, osv
27 from tools.translate import _