Merge lp:~jeff-apple/openvista-gtm-integration/listener into lp:openvista-gtm-integration

[jeff.apple]

Close listener socket in child process

[Jon Tai (jontai)]

Sorry to be nitpicky, but can you revert the whitespace changes in ZISTCPS.m?

Also, it looks like there's some debugging code left over in GTMLNCH^%ZISTCPS.

I haven't tested the changes yet, but I can follow what it's doing and it seems correct to me.

gtmserver.c and openvista.xc.in look good.

I'll give it some testing and file a bug for it before I merge. Good work tracking this one down!

[lp:~jeff-apple/openvista-gtm-integration/listener]

145. By jeff.apple on 2010-12-01

No logic changes. Just whitespace and comment.

[jeff.apple (jeff-apple)]

> Sorry to be nitpicky, but can you revert the whitespace changes in ZISTCPS.m?
>
> Also, it looks like there's some debugging code left over in GTMLNCH^%ZISTCPS.
>
> I haven't tested the changes yet, but I can follow what it's doing and it
> seems correct to me.
>
> gtmserver.c and openvista.xc.in look good.
>
> I'll give it some testing and file a bug for it before I merge. Good work
> tracking this one down!

This fixes the whitespace changes and debugging cruft. I'm not sure how to get LP to show a decent on-screen diff, but the "Diff against target" looks right.

[Jon Tai (jontai)]

Looks good. I'll hopefully get around to testing this tomorrow.

review: Approve

[Jon Tai (jontai)]

I was able to start the RPC broker, force the PIDs on my system to roll over, and telnet to the broker. netstat -lpn confirmed that the port is only attached to the listener process, not the child.

I was also able to establish a connection to the RPC broker with a real client, shut down the listener, and and start a new one without dropping the established connection.

Everything looks good -- I'll start packaging this now.

=== modified file 'mumps/ZISTCPS.m'
--- mumps/ZISTCPS.m	2009-06-05 20:09:12 +0000
+++ mumps/ZISTCPS.m	2010-12-01 20:50:10 +0000
@@ -1,4 +1,4 @@
-%ZISTCPS ;ISF/RWF MSC/JDA - DEVICE HANDLER TCP/IP SERVER CALLS ;22APR2009
+%ZISTCPS ;ISF/RWF MSC/JDA - DEVICE HANDLER TCP/IP SERVER CALLS ;01DEC2010
  ;;8.0;KERNEL;**78,118,127,225,275,388,MSC**;Jul 10, 1995
  Q
  ;
@@ -69,8 +69,11 @@
  U NIO S NIO("ZISTCP",0)=$KEY D LOG("Have port.")
  ;Start Listening
  W /LISTEN(1) S NIO("ZISTCP",1)=$KEY D LOG("Start Listening. "_NIO("ZISTCP",1))
- N ZC,ZR,IDX,DESC
+ N ZC,ZR,IDX,DESC,LDESC
  S ZC="ZSHOW ""D"":ZR"
+ X ZC
+ ; Find the listener file descriptor. The child must close it.
+ S LDESC="" F IDX=1:1:$O(ZR("D",""),-1) S:(ZR("D",IDX)["listener")&(ZR("D",IDX)["PORT="_SOCK) LDESC=$P($P(ZR("D",IDX),"DESC=",2)," ",1) Q:LDESC'=""
  ;Wait for connection
 LG2 S %A=0,EXIT=0 F  D  Q:%A!EXIT
  . U NIO:(SOCKET="listener")
@@ -91,7 +94,7 @@
  S DESC="" F IDX=1:1:$O(ZR("D",""),-1) S:ZR("D",IDX)[NIO("SOCK") DESC=$P($P(ZR("D",IDX),"DESC=",2)," ",1) Q:DESC'=""
  I DESC="" D LOG("Can not find file descriptor!") G LG2
  ;spawn child process
- S SPAWNID=$&openvista.gtmserver(DESC,"GTMLNCH^%ZISTCPS")
+ S SPAWNID=$&openvista.gtmserver(DESC,LDESC,"GTMLNCH^%ZISTCPS")
  L +^TMP("ZISTCPS",SPAWNID)
  S ^TMP("ZISTCPS",SPAWNID)=RTN
  L -^TMP("ZISTCPS",SPAWNID)

=== modified file 'src/libopenvista/gtmserver.c'
--- src/libopenvista/gtmserver.c	2009-04-23 04:45:12 +0000
+++ src/libopenvista/gtmserver.c	2010-12-01 20:50:10 +0000
@@ -26,7 +26,7 @@
 #define RETRY_EINTR(x) for(;;) if ((x)!=EINTR) break
 #define SEND_PID (write(fds[1], &grandchild_id, sizeof(int)))
 
-xc_long_t gtmserver(int count, int connfd, const char *cmd) {
+xc_long_t gtmserver(int count, int connfd, int listen_fd, const char *cmd) {
   int fds[2];
   int child_id;
   int grandchild_id;
@@ -49,6 +49,7 @@
   }
   if (child_id==0) {
     /* In child */
+    RETRY_EINTR(close(listen_fd));
     RETRY_EINTR(result=close(fds[0]) );
     if (result != 0) {
       perror("child close()");

=== modified file 'src/libopenvista/openvista.xc.in'
--- src/libopenvista/openvista.xc.in	2009-07-08 04:08:14 +0000
+++ src/libopenvista/openvista.xc.in	2010-12-01 20:50:10 +0000
@@ -1,2 +1,2 @@
 @GTM_DIST@/libopenvista.so
-gtmserver: xc_long_t gtmserver(I:xc_long_t, I:xc_char_t*)
+gtmserver: xc_long_t gtmserver(I:xc_long_t, I:xc_long_t, I:xc_char_t*)