Merge lp:~jdstrand/click/click-codify-appid into lp:click

Proposed by Jamie Strandboge
Status: Merged
Merged at revision: 204
Proposed branch: lp:~jdstrand/click/click-codify-appid
Merge into: lp:click
Diff against target: 58 lines (+15/-13)
2 files modified
doc/file-format.rst (+10/-9)
doc/hooks.rst (+5/-4)
To merge this branch: bzr merge lp:~jdstrand/click/click-codify-appid
Reviewer Review Type Date Requested Status
Colin Watson Approve
Review via email: mp+179790@code.launchpad.net

Description of the change

* codify allowed characters for "application ID"
* fix typos in apparmor hook example

To post a comment you must log in.
203. By jdstrand <Jamie Strandboge <email address hidden>>

doc/hooks.rst: application name can also have upper case letters

Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/file-format.rst'
2--- doc/file-format.rst 2013-08-05 00:08:42 +0000
3+++ doc/file-format.rst 2013-08-12 20:30:12 +0000
4@@ -79,17 +79,18 @@
5 the value of "framework" does not declare a framework implemented by the
6 system on which the package is being installed.
7
8-The value of "name" identifies the application; every package in the app
9-store has a unique "name" identifier, and the app store will reject clashes.
10-It is the developer's responsibility to choose a unique identifier. The
11-recommended approach is to follow the Java package name convention, i.e.
12-"com.mydomain.myapp", starting with the reverse of an Internet domain name
13-owned by the person or organisation developing the application; note that it
14-is not necessary for the application to contain any Java code in order to
15-use this convention.
16+The value of "name" identifies the application, following Debian source
17+package name rules; every package in the app store has a unique "name"
18+identifier, and the app store will reject clashes. It is the developer's
19+responsibility to choose a unique identifier. The recommended approach is
20+to follow the Java package name convention, i.e. "com.mydomain.myapp",
21+starting with the reverse of an Internet domain name owned by the person or
22+organisation developing the application; note that it is not necessary for
23+the application to contain any Java code in order to use this convention.
24
25 The value of "version" provides a unique version for the application,
26-following Debian version numbering rules.
27+following Debian version numbering rules. See deb-version(5) for full
28+details.
29
30 For future expansion (e.g. applications that require multiple frameworks),
31 the syntax of "framework" is formally that of a Debian dependency
32
33=== modified file 'doc/hooks.rst'
34--- doc/hooks.rst 2013-08-06 10:00:47 +0000
35+++ doc/hooks.rst 2013-08-12 20:30:12 +0000
36@@ -77,8 +77,9 @@
37 will be only one). Each application has a name.
38
39 * An "application ID" is a string unique to each application instance: it
40- is made up of the Click package name, the application name, and the Click
41- package version joined by underscores, e.g.
42+ is made up of the Click package name, the application name (must consist
43+ of only of characters for a Debian source package name, Debian version
44+ and [A-Z]), and the Click package version joined by underscores, e.g.
45 ``com.ubuntu.clock_alarm_0.1``.
46
47 * An integrated-with system package may add ``*.hook`` files to
48@@ -193,8 +194,8 @@
49 ::
50
51 /usr/share/click/hooks/apparmor.hook:
52- Pattern: /var/lib/apparmor/click/${id}.json
53- Exec: aa-click
54+ Pattern: /var/lib/apparmor/clicks/${id}.json
55+ Exec: /usr/bin/aa-clickhook
56 User: root
57
58 /usr/share/click/hooks/click-desktop.hook:

Subscribers

People subscribed via source and target branches