Code review comment for lp:~jderose/ubuntu/trusty/couchdb/1.5.0

awesome! I'm partway through pulling this "back" to work on precise
too. I'll send more details through when I'm past the stupid error
stage..

(1) this is quite linux specific and vendor-specific. I'm +0 on
teaching couchdb configure scripts to handle different distros but if
lsb_release is available (at least as a package) on all linux flavours
then its not unreasonable.

(2) seems pretty sensible. some caveats:

upstart is not clear if static-network-up is available on dhcp or
not; according to man upstart-events in precise, its emitted when the
last static interface is up.

deconfiguring-networking; would this break a couchdb instance being
used as an offline-capable application? FWIW it isn't available on
precise but that shouldn't matter if it works for you.

A+
Dave

On 2 December 2013 05:05, Jason Gerard DeRose <email address hidden> wrote:
> Review: Resubmit
>
> Dave, okay, I finished the requested changes, and am ready for another review. I made two important changes:
>
> 1) The default.ini file now gets the appropriate [vendor] info from `lsb_release`
>
> I'd really like to see an easier way of doing this implemented upstream, but I think my approach is workable for now, though a bit hacky.
>
> 2) I tweaked the couchdb.upstart config mostly based on your suggestions
>
> Based on my reading of this:
> http://upstart.ubuntu.com/cookbook/#ubuntu-well-known-events-ubuntu-specific
>
> I feel it's most correct to:
> start on filesystem and static-network-up
> stop on deconfiguring-networking
>
> I've tested start/stop, stop via apt-get remove/purge, and respawn (by manually killing the couchdb process).
> --
> https://code.launchpad.net/~jderose/ubuntu/trusty/couchdb/1.5.0/+merge/197291
> You are reviewing the proposed merge of lp:~jderose/ubuntu/trusty/couchdb/1.5.0 into lp:ubuntu/couchdb.