Merge lp:~jderose/system76-driver/systemd into lp:system76-driver

Proposed by Jason Gerard DeRose
Status: Merged
Merged at revision: 307
Proposed branch: lp:~jderose/system76-driver/systemd
Merge into: lp:system76-driver
Diff against target: 38 lines (+11/-1)
3 files modified
debian/control (+1/-0)
debian/rules (+1/-1)
debian/system76-driver.service (+9/-0)
To merge this branch: bzr merge lp:~jderose/system76-driver/systemd
Reviewer Review Type Date Requested Status
David Overcash (community) Approve
Review via email: mp+246656@code.launchpad.net

Description of the change

First pass at adding systemd support:

 * debian/control: add "dh-systemd" to Build-Depends

 * debian/rules: call dh "--with=systemd"

 * debian/system76-driver.service: basic systemd unit file for starting `system76-daemon`

I tested this on Vivid, and it seemingly work fine. Likely will need further tuning, but at least this means folks who are using systemd wont get an apport crash report every time there's a new system76-driver release. (Wink, wink, Kevin Cole!)

This merge should have no effect on customers using Upstart (what Ubuntu currently uses by default). The existing Upstart job is still there and remains unchanged. This system76-driver.service file only takes effect when systemd is PID 1.

On Vivid, you can test this easily by holding shift as you boot your computer to show the grub menu, and then in "Advanced options for Ubuntu", there will be a "Linux ... (systemd)" entry for each kernel you have installed.

For great docs on porting Upstart jobs to systemd, see:

https://wiki.ubuntu.com/SystemdForUpstartUsers

To post a comment you must log in.
Revision history for this message
David Overcash (funnylookinhat) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-11-07 19:49:47 +0000
3+++ debian/control 2015-01-15 21:55:22 +0000
4@@ -3,6 +3,7 @@
5 Priority: extra
6 Maintainer: System76, Inc. <dev@system76.com>
7 Build-Depends: debhelper (>= 9),
8+ dh-systemd,
9 python3-all (>= 3.4),
10 pyflakes,
11 xvfb,
12
13=== modified file 'debian/rules'
14--- debian/rules 2013-06-20 02:54:48 +0000
15+++ debian/rules 2015-01-15 21:55:22 +0000
16@@ -1,7 +1,7 @@
17 #!/usr/bin/make -f
18
19 %:
20- dh $@ --with=python3
21+ dh $@ --with=python3,systemd
22
23
24 override_dh_auto_clean:
25
26=== added file 'debian/system76-driver.service'
27--- debian/system76-driver.service 1970-01-01 00:00:00 +0000
28+++ debian/system76-driver.service 2015-01-15 21:55:22 +0000
29@@ -0,0 +1,9 @@
30+[Unit]
31+Description=System76 airplane-mode hotkey and LED support
32+
33+[Service]
34+ExecStart=/usr/lib/system76-driver/system76-daemon
35+
36+[Install]
37+WantedBy=multi-user.target
38+

Subscribers

People subscribed via source and target branches