Merge lp:~jderose/system76-driver/fix-1378974 into lp:system76-driver

Proposed by Jason Gerard DeRose
Status: Merged
Merged at revision: 263
Proposed branch: lp:~jderose/system76-driver/fix-1378974
Merge into: lp:system76-driver
Diff against target: 12 lines (+1/-1)
1 file modified
debian/system76-driver.upstart (+1/-1)
To merge this branch: bzr merge lp:~jderose/system76-driver/fix-1378974
Reviewer Review Type Date Requested Status
David Overcash (community) Approve
Review via email: mp+238201@code.launchpad.net

Description of the change

For more background, please see:
https://bugs.launchpad.net/system76-driver/+bug/1378974

"start on (login-session-start or desktop-session-start)" seems to do the trick... I didn't experience a single brightness restore failures when testing with this modified Upstart job over the weekend, whereas the current system76-driver daily build for Utopic fails to restore the brightness very frequently (certainly over 50% of the time, at least on Intel GPU systems).

Looking at /etc/init/lightdm.conf more closely, I'd say this new Upstart job is generally more correct regardless of this specific bug, but the important thing is this change has proven to fix our problem.

I'm not going to dig into what changes in lightdm, etc., might have caused this regression, as there are many other higher priority bugs I still need to fry.

To post a comment you must log in.
Revision history for this message
David Overcash (funnylookinhat) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/system76-driver.upstart'
2--- debian/system76-driver.upstart 2013-11-14 20:07:30 +0000
3+++ debian/system76-driver.upstart 2014-10-13 18:48:32 +0000
4@@ -4,7 +4,7 @@
5
6 description "System76 airplane-mode hotkey and LED support"
7
8-start on login-session-start
9+start on (login-session-start or desktop-session-start)
10 stop on desktop-shutdown
11
12 respawn

Subscribers

People subscribed via source and target branches