Merge lp:~jderose/system76-driver/fix-1356507 into lp:system76-driver

[Jason Gerard DeRose]

For background, please see:
https://bugs.launchpad.net/system76-driver/+bug/1356507

Changes:

 * Drop `actions.disable_power_well` from daru4, galu1, gazp9, gazp9b, kudp1, kudp1b

 * Remove `actions.disable_power_well` and its tests

 * Add debian/changelog entry

[David Overcash (funnylookinhat)]

Looks rock solid.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2014-09-22 19:38:31 +0000
+++ debian/changelog	2014-09-22 20:55:08 +0000
@@ -1,6 +1,8 @@
 system76-driver (14.10.0~pre1) utopic; urgency=low
 
     * Start 14.10.x series, initial Utopic release
+    * Drop `disable_power_well` action as it's no longer needed for Haswell
+      laptop products with the Linux 3.16 kernel (LP: #1356507)
     * FILL ME IN
 
  -- Jason Gerard DeRose <[e-mail]>  Mon, 22 Sep 2014 13:34:50 -0600

=== modified file 'system76driver/actions.py'
--- system76driver/actions.py	2014-05-08 23:01:33 +0000
+++ system76driver/actions.py	2014-09-22 20:55:08 +0000
@@ -349,20 +349,6 @@
         return _('Enable Radeon GPU power management')
 
 
-class disable_power_well(GrubAction):
-    """
-    Add i915.disable_power_well=0 to GRUB_CMDLINE_LINUX_DEFAULT.
-
-    This fixes the HDMI playback speed issue on Intel Haswell GPUs (playback
-    speed is faster than it should be, aka the "chipmunk problem").
-    """
-
-    add = ('i915.disable_power_well=0',)
-
-    def describe(self):
-        return _('Fix HDMI audio playback speed')
-
-
 class plymouth1080(Action):
     update_grub = True
     value = 'GRUB_GFXPAYLOAD_LINUX="1920x1080"'

=== modified file 'system76driver/products.py'
--- system76driver/products.py	2014-09-04 18:09:44 +0000
+++ system76driver/products.py	2014-09-22 20:55:08 +0000
@@ -86,7 +86,6 @@
             actions.wifi_pm_disable,
             actions.hdmi_hotplug_fix,
             actions.backlight_vendor,
-            actions.disable_power_well,
             actions.internal_mic_gain,
         ],
     },
@@ -98,7 +97,6 @@
             actions.wifi_pm_disable,
             actions.internal_mic_gain,
             actions.hdmi_hotplug_fix,
-            actions.disable_power_well,
         ],
     },
 
@@ -141,7 +139,6 @@
         'drivers': [
             actions.wifi_pm_disable,
             actions.hdmi_hotplug_fix,
-            actions.disable_power_well,
             actions.backlight_vendor,  # Still needed for some early BIOS
         ],
     },
@@ -150,7 +147,6 @@
         'drivers': [
             actions.wifi_pm_disable,
             actions.hdmi_hotplug_fix,
-            actions.disable_power_well,
             actions.remove_backlight_vendor,
             actions.internal_mic_gain,  # Only for gazp9b
         ],
@@ -194,7 +190,6 @@
         'drivers': [
             actions.wifi_pm_disable,
             actions.hdmi_hotplug_fix,
-            actions.disable_power_well,
         ],
     },
     'kudp1b': {
@@ -202,7 +197,6 @@
         'drivers': [
             actions.wifi_pm_disable,
             actions.hdmi_hotplug_fix,
-            actions.disable_power_well,
             actions.internal_mic_gain,  # Only for kudp1b
         ],
     },

=== modified file 'system76driver/tests/test_actions.py'
--- system76driver/tests/test_actions.py	2014-05-08 23:01:33 +0000
+++ system76driver/tests/test_actions.py	2014-09-22 20:55:08 +0000
@@ -805,24 +805,6 @@
         )
 
 
-class Test_disable_power_well(TestCase):
-    def test_describe(self):
-        inst = actions.disable_power_well()
-        self.assertEqual(inst.describe(),
-            'Fix HDMI audio playback speed'
-        )
-
-    def test_build_new_cmdline(self):
-        inst = actions.disable_power_well()
-        self.assertEqual(inst.add,
-            ('i915.disable_power_well=0',)
-        )
-        self.assertEqual(inst.remove, tuple())
-        self.assertEqual(inst.build_new_cmdline('quiet splash'),
-            'i915.disable_power_well=0 quiet splash'
-        )
-
-
 class Test_plymouth1080(TestCase):
     def test_init(self):
         inst = actions.plymouth1080()