FileStore

Merge lp:~jderose/filestore/statvfs into lp:filestore

  1. statvfs
  2. Merge into trunk
Proposed by Jason Gerard DeRose
Status: Merged
Merged at revision: 187
Proposed branch: lp:~jderose/filestore/statvfs
Merge into: lp:filestore
Diff against target: 0 lines
To merge this branch: bzr merge lp:~jderose/filestore/statvfs
Reviewer Review Type Date Requested Status
Manish Sinha (मनीष सिन्हा) (community) Approve
dmedia Dev Pending
Review via email: mp+74901@code.launchpad.net

Description of the change

Adds the FileStore.statvfs() method and its test. Should be very self-explanatory :^)

To post a comment you must log in.
lp:~jderose/filestore/statvfs updated
190. By Jason Gerard DeRose

Small clairification

191. By Jason Gerard DeRose

avail is most important, so make it first item in StatVFS

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

Please clarify in the comments whether the size returned as a namedtuple is in bytes, kilobytes.

I can make out it is in bytes, but being explicit is always better. It avoids confusion.

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

Also please mention whether this available space is only for the current volume or the complete hard disk (including all volumes)

Apart from updation of comments, I find everything to be OK

review: Approve
lp:~jderose/filestore/statvfs updated
192. By Jason Gerard DeRose

docstring clairification

Preview Diff

Empty

Subscribers

People subscribed via source and target branches