launchpadlib

Merge lp:~jcsackett/launchpadlib/add-qastaging-to-uris into lp:launchpadlib

  1. add-qastaging-to-uris
  2. Merge into trunk
Proposed by j.c.sackett
Status: Merged
Merged at revision: 99
Proposed branch: lp:~jcsackett/launchpadlib/add-qastaging-to-uris
Merge into: lp:launchpadlib
Diff against target: 48 lines (+5/-1)
2 files modified
src/launchpadlib/tests/test_launchpad.py (+1/-1)
src/launchpadlib/uris.py (+4/-0)
To merge this branch: bzr merge lp:~jcsackett/launchpadlib/add-qastaging-to-uris
Reviewer Review Type Date Requested Status
Leonard Richardson (community) Approve
Review via email: mp+39483@code.launchpad.net

Commit message

Adds the qastaging information to the launchpadlib uris.

Description of the change

Summary
=======

Adds qastaging as root for launchapdlib

Implementation
==============

Adds the qastaging api data to launchpadlib.uris and updates the tests for aliases to include "qastaging" as an alias.

Demo/QA
========
>>> from launchpadlib.launchpad import Launchpad
>>> lp = Launchpad.login_with('testing', 'qastaging', <yourcachedir>)

To post a comment you must log in.
Revision history for this message
Leonard Richardson (leonardr) wrote :

Add a mention in the NEWS.txt and you can land this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/launchpadlib/tests/test_launchpad.py'
2--- src/launchpadlib/tests/test_launchpad.py 2010-08-23 19:51:55 +0000
3+++ src/launchpadlib/tests/test_launchpad.py 2010-10-27 22:08:44 +0000
4@@ -75,7 +75,7 @@
5
6 def setUp(self):
7 self.aliases = sorted(
8- ['production', 'edge', 'staging', 'dogfood', 'dev', 'test_dev'])
9+ ['production', 'edge', 'qastaging', 'staging', 'dogfood', 'dev', 'test_dev'])
10
11 def test_short_names(self):
12 # Ensure the short service names are all supported.
13
14=== modified file 'src/launchpadlib/uris.py'
15--- src/launchpadlib/uris.py 2010-02-15 16:34:26 +0000
16+++ src/launchpadlib/uris.py 2010-10-27 22:08:44 +0000
17@@ -30,6 +30,7 @@
18
19 LPNET_SERVICE_ROOT = 'https://api.launchpad.net/'
20 EDGE_SERVICE_ROOT = 'https://api.edge.launchpad.net/'
21+QASTAGING_SERVICE_ROOT = 'https://api.qastaging.launchpad.net/'
22 STAGING_SERVICE_ROOT = 'https://api.staging.launchpad.net/'
23 DEV_SERVICE_ROOT = 'https://api.launchpad.dev/'
24 DOGFOOD_SERVICE_ROOT = 'https://api.dogfood.launchpad.net/'
25@@ -37,6 +38,7 @@
26
27 LPNET_WEB_ROOT = 'https://launchpad.net/'
28 EDGE_WEB_ROOT = 'https://edge.launchpad.net/'
29+QASTAGING_WEB_ROOT = 'https://qastaging.launchpad.net/'
30 STAGING_WEB_ROOT = 'https://staging.launchpad.net/'
31 DEV_WEB_ROOT = 'https://launchpad.dev/'
32 DOGFOOD_WEB_ROOT = 'https://dogfood.launchpad.net/'
33@@ -46,6 +48,7 @@
34 service_roots = dict(
35 production=LPNET_SERVICE_ROOT,
36 edge=EDGE_SERVICE_ROOT,
37+ qastaging=QASTAGING_SERVICE_ROOT,
38 staging=STAGING_SERVICE_ROOT,
39 dogfood=DOGFOOD_SERVICE_ROOT,
40 dev=DEV_SERVICE_ROOT,
41@@ -56,6 +59,7 @@
42 web_roots = dict(
43 production=LPNET_WEB_ROOT,
44 edge=EDGE_WEB_ROOT,
45+ qastaging=QASTAGING_WEB_ROOT,
46 staging=STAGING_WEB_ROOT,
47 dogfood=DOGFOOD_WEB_ROOT,
48 dev=DEV_WEB_ROOT,

Subscribers

People subscribed via source and target branches