Merge lp:~jcsackett/launchpad/sharing-details-breadcrumb into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 15069 | ||||
Proposed branch: | lp:~jcsackett/launchpad/sharing-details-breadcrumb | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
119 lines (+27/-9) 5 files modified
lib/lp/registry/browser/configure.zcml (+6/-1) lib/lp/registry/browser/pillar.py (+13/-2) lib/lp/registry/browser/tests/test_pillar_sharing.py (+6/-4) lib/lp/registry/javascript/sharing/shareetable.js (+1/-1) lib/lp/registry/javascript/sharing/tests/test_shareetable.js (+1/-1) |
||||
To merge this branch: | bzr merge lp:~jcsackett/launchpad/sharing-details-breadcrumb | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+100498@code.launchpad.net |
Commit message
Sets up the breadcrumb for the sharing details page.
Description of the change
Summary
=======
This branch adds breadcrumb info for the sharing details page. It also alters
the url for the sharing details page, slightly, from
+sharingdetails
url structure we agreed upon previously. Ideally, it would be
+sharing/
traversal structure. The previous url (+sharingdetails) was believed to be
necessary at the time, that's not true.
Of note, this doesn't complete the breadcrumb setup as seen in mockups[1], but
as the managing disclosure view doesn't have any corresponding interface
beyond the pillar, it's not added into the traversed_objects for the Hierarchy
interface to convert into a breadcrumb. There are probably ways around this,
but sorting them out was delaying the useful bit of code contained in this
branch, i.e. a proper breadcrumb for the sharing details page.
[1]: http://
Preimp
======
None
Implementation
==============
This branch adds a simple IBreadCrumb adapter for the PillarPerson interface,
providing the name of the person in the pillar person as the breadcrumb text.
The zcml for the details page has been updated, as has the stepthrough
decorator for the NavigationMixin to alter the url from +sharingdetails to
+sharing.
Tests
=====
bin/test -vvct pillar_sharing
QA
==
Go to a sharing details page via +sharing/
verifying the url change.
Additionally, the page should have a breadcrumb of $pillarname >> $personname
Lint
====
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
Until we sort out the intermediate breadcrumb, I think the text should probably include "sharing details" somewhere.