Merge lp:~jcsackett/launchpad/registry-setting-account-status into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Robert Collins | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12579 | ||||
Proposed branch: | lp:~jcsackett/launchpad/registry-setting-account-status | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
58 lines (+10/-3) 3 files modified
lib/canonical/launchpad/browser/launchpad.py (+1/-1) lib/lp/app/browser/tests/test_launchpad.py (+8/-1) lib/lp/registry/browser/tests/person-admin-views.txt (+1/-1) |
||||
To merge this branch: | bzr merge lp:~jcsackett/launchpad/registry-setting-account-status | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+52626@code.launchpad.net |
Commit message
[r=lifeless][bug=730011] Changes permissions on suspended accounts to launchpad.Moderate, so LOSAs aren't needed to unsuspend an account.
Description of the change
Summary
=======
Registry admins can suspend accounts, but are unable to view accounts that are suspended. This means that they are unable to address the needs of users who have legitimate reason/need to reactivate an account without contacting the LOSAs.
This branch gives people with "launchpad.
Implementation
==============
The check for "launchpad.Admin" when traversing on a suspended user is changed to "launchpad.
Tests
=====
bin/test -t test_suspended_
Demo & QA
=========
Attempt to open a suspended person's page while not logged in; you should get the usual error.
Attempt to open the same page logged in as a member of registry experts; you should see the page.