Merge lp:~jcsackett/launchpad/redundant-message-is-redundant into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Brad Crittenden | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 14448 | ||||
Proposed branch: | lp:~jcsackett/launchpad/redundant-message-is-redundant | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
50 lines (+16/-5) 2 files modified
lib/lp/bugs/browser/bugtask.py (+14/-3) lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+2/-2) |
||||
To merge this branch: | bzr merge lp:~jcsackett/launchpad/redundant-message-is-redundant | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+84308@code.launchpad.net |
Commit message
[r=bac][bug=898584] Updates messages for deleted bug tasks to be less redundant.
Description of the change
Summary
=======
Recently the ability to delete bugtasks was introduced; the bugactivity
message for this event was flagged by mpt as redundant.
This branch updates the message displayed in comment activity for deleted
bugtasks.
Ordinarily the easiest approach would be to change the "whatchanged" value
stored for deleted bug tasks in the DB. However, in this instance there is a
mismatch between the value stored and what we want to show. "bug task deleted"
is the most logical thing to store in the DB, as that *is* the event and is
useful for lp developers. But our UI talks about "affecting" and "no longer
affects". To get around this, the branch introduces a "better_summary" option
for bug changes that have this sort of mismatch.
Preimp
======
None
Implementation
==============
* bugchanges have a new method, better_summary, which takes a summary and
better summary if available. For now, this is only used for
'bug task deleted', but can easily be used for other bug activity events.
* the change details return value for 'bug task deleted' is now just the id of
the deleted task.
Test
====
bin/test -vvct bug-activity
bin/test -vvct bugchanges
QA
==
Find a bug with a deleted bug task (or set one up). The activity logged in
comments should be
{{{ no longer affects:
Lint
====
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
Nice change Jonathan.
The assignment at line 15 is unnecessary.