Merge lp:~jcsackett/launchpad/private-bugs-open-teams-and-delegate-teams-oh-my into lp:launchpad

[j.c.sackett]

[r=bac][bug=878531] Provides a better error message to webapp user when they try to subscribe open/delegated teams to private bugs.

Summary
=======
You can no longer add open or delegated teams as a subscriber on a private
bug. This is implemented on the model/API level, and handled by try/except on
the view level. However, subscription in the webapp is actually managed by
javascript, which was simply returning the 400 BAD REQUEST data as an error
msg.

This branch updates the subscriber error handler to show response text error
msg, if it exists.

Preimplementation
=================
None

Implementation
==============
In the _subscribe function's error handling, we now check if an error
condition occurred (response code of 400) and if response text exists. If
those conditions are met, we know we're getting an error message from the API,
which we should display. We pass that along as the error msg instead of the
bad request data.

Tests
=====
bin/test -vvc --layer=YUI

QA
==
Attempt to add an open/delegated team to a private bug. You will receive an
error message saying that open and delegated teams can't be subscribed to
private bugs, as you would via an API call.

Lint
====
This branch is lint free.

[Brad Crittenden (bac)]

Looks good Jonathan.

review: Approve (code)

=== modified file 'lib/lp/app/javascript/subscribers/subscribers_list.js'
--- lib/lp/app/javascript/subscribers/subscribers_list.js	2011-09-16 00:11:16 +0000
+++ lib/lp/app/javascript/subscribers/subscribers_list.js	2011-11-18 16:26:25 +0000
@@ -512,10 +512,16 @@
         } else {
             loader.subscribers_list.stopActivity();
         }
+        if (response.status === 400 && response.responseText !== undefined) {
+            error_msg = response.responseText;
+        } else {
+            error_msg = (
+                response.status + " (" + response.statusText + "). " +
+                "Failed to subscribe " + subscriber.display_name + ".");
+        }
         Y.lp.app.errors.display_error(
             false,
-            response.status + " (" + response.statusText + "). " +
-                "Failed to subscribe " + subscriber.display_name + "."
+            error_msg
         );
     }
     var config = {