Merge lp:~jcsackett/launchpad/privacy-banner-better-text-ff-redo into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15338 |
Proposed branch: | lp:~jcsackett/launchpad/privacy-banner-better-text-ff-redo |
Merge into: | lp:launchpad |
Diff against target: |
157 lines (+67/-5) 6 files modified
lib/lp/app/browser/informationtype.py (+2/-0) lib/lp/app/templates/banner-macros.pt (+10/-1) lib/lp/bugs/browser/bugtask.py (+13/-0) lib/lp/bugs/browser/tests/test_bugtask.py (+15/-0) lib/lp/bugs/javascript/information_type_choice.js (+17/-0) lib/lp/bugs/javascript/tests/test_information_type_choice.js (+10/-4) |
To merge this branch: | bzr merge lp:~jcsackett/launchpad/privacy-banner-better-text-ff-redo |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+108071@code.launchpad.net |
Description of the change
Summary
=======
A branch was created that shows the type of private information when
applicable (e.g. User Data, Embargoed Security). This branch did not however
factor in the requirement that this behavior only be in effect when the
appropriate feature flags are set.
That branch was rolled back; this branch undoes that rollback and adds the
necessary feature flag checks.
Implementation
==============
The information_type property of the BugtaskIndexView now uses the necessary
feature flags in determining what to return.
The flag indicating use of the term "Privacy" vs "User Data" is now added to
the LP.cache in the same manner as the one that establishes whether to show
information_type in the UI.
The creation of the updated banner text in information_
its own small method; it now checks the feature flags to determine how to
update the banner text.
Tests
=====
bin/test -vvct test_bugtask
bin/test -vvct type_choice --layer=YUI
QA
==
Check the text in the privacy banner on a bugtask index page under all
combinations of the relevant feature flags.
LoC
===
This is part of disclosure work.
Lint
====
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
thank you.