Merge lp:~jcsackett/launchpad/packaging-portlet-timeouts into lp:launchpad

[j.c.sackett]

Disables the needs_linking feature and removes its display from the template. Previously users would see the "top ten" packages needing linking, which appeared to be not completely valid data, and was the cause of timeouts.

lp:~jcsackett/launchpad/packaging-portlet-timeouts
    Diff size: 43 lines
    Launchpad bug:
          https://bugs.launchpad.net/bugs/612358
    Test command: ./bin/test -vv \
          -t test_needs_linking
    Pre-implementation: sinzui (Curtis Hovey)
    Target release: 10.08

Disable the "needs linked" feature in the packaging-portlet
--------------------------------------------------------------------

Related to bug 612358, we needed to disable the needs linked portion
of the packaging-portlet. The current presentation isn't really
meeting the need of encouraging participation in linking packages,
and is showing bad data (bad bug count, packages that can't be
linked).

QA
--

Open a project with the packaging-portlet; the needs more
information part should no longer display.

Lint
----

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/browser/distroseries.py
  lib/lp/registry/browser/tests/test_distroseries_views.py
  lib/lp/registry/templates/distroseries-portlet-packaging.pt

Test
----

test_needs_linking in
/lib/lp/registry/browser/tests/test_distroseries.py
was updated to assert that view.needs_linked returns None

Implementation
--------------

In the portlet:
    * Removed the preprocessing so that the data no longer
      displays, turning off the feature
In the view:
    * Updated the needs_linked property to return None

Together, this disables the feature.

[Robert Collins (lifeless)]

review: Approve

[Brad Crittenden (bac)]

Please include the test change from Edwin's branch

review: Needs Fixing (code)

[Brad Crittenden (bac)]

review: Approve (code)

=== modified file 'lib/lp/registry/browser/distroseries.py'
--- lib/lp/registry/browser/distroseries.py	2010-08-02 02:13:52 +0000
+++ lib/lp/registry/browser/distroseries.py	2010-08-06 12:57:49 +0000
@@ -332,7 +332,9 @@
     @cachedproperty
     def needs_linking(self):
         """Return a list of 10 packages most in need of upstream linking."""
-        return self.context.getPrioritizedUnlinkedSourcePackages()[:10]
+        # XXX sinzui 2010-02-26 bug=528648: This method causes a timeout.
+        # return self.context.getPrioritizedUnlinkedSourcePackages()[:10]
+        return None
 
     milestone_can_release = False
 

=== modified file 'lib/lp/registry/browser/tests/test_distroseries_views.py'
--- lib/lp/registry/browser/tests/test_distroseries_views.py	2010-07-28 14:05:12 +0000
+++ lib/lp/registry/browser/tests/test_distroseries_views.py	2010-08-06 12:57:49 +0000
@@ -42,10 +42,7 @@
         ubuntu = getUtility(ILaunchpadCelebrities).ubuntu
         distroseries = self.factory.makeDistroSeries(distribution=ubuntu)
         view = create_initialized_view(distroseries, '+index')
-        self.assertTrue(
-            IResultSet.providedBy(view.needs_linking),
-            '%s should implement IResultSet so that slicing will limit the '
-            'query' % view.needs_linking)
+        self.assertEqual(view.needs_linking, None)
 
 
 def test_suite():

=== modified file 'lib/lp/registry/stories/distroseries/xx-distroseries-index.txt'
--- lib/lp/registry/stories/distroseries/xx-distroseries-index.txt	2010-07-28 19:08:30 +0000
+++ lib/lp/registry/stories/distroseries/xx-distroseries-index.txt	2010-08-06 12:57:49 +0000
@@ -100,9 +100,5 @@
     evolution linked...
     mozilla-firefox linked...
     netapplet linked 2005-07-05
-    Needs more information or linking to upstream:
-    cdrkit
-    iceweasel
-    linux-source-2.6.15
     Needs upstream links
     All upstream links

=== modified file 'lib/lp/registry/templates/distroseries-portlet-packaging.pt'
--- lib/lp/registry/templates/distroseries-portlet-packaging.pt	2010-07-27 20:59:06 +0000
+++ lib/lp/registry/templates/distroseries-portlet-packaging.pt	2010-08-06 12:57:49 +0000
@@ -49,20 +49,6 @@
         </p>
       </tal:package>
     </dd>
-
-    <dt id="needs-linking"
-        tal:condition="view/needs_linking">
-      Needs more information or linking to upstream:
-    </dt>
-    <dd tal:condition="view/needs_linking">
-      <ul class="horizontal">
-          <li tal:repeat="package view/needs_linking">
-            <a class="sprite package-source"
-               tal:attributes="href package/package/fmt:url"
-               tal:content="package/package/name">evolution</a>
-          </li>
-      </ul>
-    </dd>
   </dl>
 
   <ul class="horizontal">