Merge lp:~jcsackett/launchpad/oh-oh-pick-me-pick-me into lp:launchpad
Status: | Merged |
---|---|
Approved by: | j.c.sackett |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13149 |
Proposed branch: | lp:~jcsackett/launchpad/oh-oh-pick-me-pick-me |
Merge into: | lp:launchpad |
Diff against target: |
215 lines (+181/-2) 4 files modified
lib/lp/app/widgets/popup.py (+1/-2) lib/lp/registry/javascript/personpicker.js (+74/-0) lib/lp/registry/javascript/tests/test_personpicker.html (+40/-0) lib/lp/registry/javascript/tests/test_personpicker.js (+66/-0) |
To merge this branch: | bzr merge lp:~jcsackett/launchpad/oh-oh-pick-me-pick-me |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Kowalik (community) | code | Approve | |
Review via email: mp+63047@code.launchpad.net |
Commit message
Creates a personpicker YUI widget
Description of the change
Summary
=======
As part of the work for disclosure, a better personpicker is needed that users can trust. The current personpicker is actually just the regular picker, passed a person-specific vocabulary. Because the personpicker will have it's own UI attributes (e.g. "Assign me" and "Remove assignee" buttons like the bug assign pickerPatcher), we need a PersonPicker YUI widget.
Preimplementation
=================
Spoke with Deryck Hodge about creating a new widget, and Curtis Hovey.
Implementation
==============
lib/lp/
-------
Drive by whitespace fixes.
lib/lp/
-------
Created PersonPicker, which extends Y.lazr.Picker. It creates an assign_me and a remove_asignee button, as those are UI elements we want when using the person picker, and wires them up to provide the users name or to clear the entry as appropriate.
lib/lp/
lib/lp/
-------
Tests.
Tests
=====
firefox lib/lp/
QA
==
None. This is a new widget not yet wired into any of the UI.
Lint
====
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Could you attach a screenshot please?