Merge lp:~jcsackett/launchpad/no-write-sharing-lies into lp:launchpad

[j.c.sackett]

Sets correct css on choicesource html when clickable_content is false, so the content is not styled as clickable.

Summary
=======
We can make +sharing read-only via flags, but the choicesource remains a
clickable item -- it sets the cursor and text-decoration as a link, but
doesn't do anything when clicked.

ChoiceSource has a clickable_content attribute--when false, the content
should not be styled as though it is clickable.

Preimp
======
Spoke with Curtis Hovey.

Implementation
==============
A new css class for the choicesource is added -- no-click. It's not named
yui3-choicesource-no-click b/c we might want to use this same css elsewhere.
It sets cursor to default and text decoration to none on hover.

On init in choicesource, if clickable_content is false, no-click is added to
the contentBox's classes.

Tests
=====
bin/test -t choiceedit --layer=YUI

QA
==
Make sure that the choicesources on +sharing aren't clickable when the
writable flag is off.

LoC
===
This is part of disclosure.

Lint
====

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/launchpad/icing/css/forms.css
  lib/lp/app/javascript/choiceedit/choiceedit.js
  lib/lp/app/javascript/choiceedit/tests/test_choiceedit.js

./lib/canonical/launchpad/icing/css/forms.css
< ... snip ... >

There are a bunch of errors in forms.css, but it's not a file I want to
reformat. I assume if every line lints wrongly the same way, there's a reason.

[Curtis Hovey (sinzui)]

I don't think this branch is complete. As a driver of a project, I can see who the project shares with, but I cannot edit.

I see this in lib/lp/registry/javascript/sharing/granteetable.js at line 244:
        var clickable_content = this.get('write_enabled');
        var permission_edit = new Y.ChoiceSource({
            clickable_content: clickable_content,

I think a drivers will see the clickable content even though they do not have the permission to make a change.
/me checks
Well I think I found another bug. As a driver, I cannot see the +sharing link or access the page :( This undermines a lot of Canonical projects.

review: Needs Information (code)

[j.c.sackett (jcsackett)]

As discussed on IRC, the clickable_content is simply what's inside the choice source--the content is always rendered, and *should* be. The only thing being altered by that var is whether or not the rendered content should behave as clickable.

Previously, all that meant was whether or not clicking brought up the ChoiceList--with this branch it means that said content doesn't behave as a link--text-decoration stays None and cursor stays Default.

The drivers issue is, as discussed on IRC, a separate bug.

[Curtis Hovey (sinzui)]

Thank you for explaining the situation to me. I think this is good to land.

review: Approve (code)

=== modified file 'lib/canonical/launchpad/icing/css/forms.css'
--- lib/canonical/launchpad/icing/css/forms.css	2012-07-31 08:29:31 +0000
+++ lib/canonical/launchpad/icing/css/forms.css	2012-08-08 17:18:30 +0000
@@ -264,6 +264,12 @@
     text-decoration: underline;
     cursor: pointer;
     }
+
+.no-click:hover {
+    text-decoration: none !important;
+    cursor: default !important;
+    }
+    
 .yui3-buglisting-config-util a {
     position: relative;
     top: 3px;

=== modified file 'lib/lp/app/javascript/choiceedit/choiceedit.js'
--- lib/lp/app/javascript/choiceedit/choiceedit.js	2012-06-29 19:36:57 +0000
+++ lib/lp/app/javascript/choiceedit/choiceedit.js	2012-08-08 17:18:30 +0000
@@ -171,6 +171,10 @@
          * @preventable _saveData
          */
         this.publish(SAVE);
+        if (!this.get('clickable_content')) {
+            var content = this.get('contentBox');
+            content.addClass('no-click');
+        };
     },
 
     /**

=== modified file 'lib/lp/app/javascript/choiceedit/tests/test_choiceedit.js'
--- lib/lp/app/javascript/choiceedit/tests/test_choiceedit.js	2012-06-15 18:35:20 +0000
+++ lib/lp/app/javascript/choiceedit/tests/test_choiceedit.js	2012-08-08 17:18:30 +0000
@@ -331,8 +331,13 @@
               "ChoiceList object is not being created");
             Assert.isNotNull(Y.one(document).one(".yui3-ichoicelist"),
               "ChoiceList HTML is not being added to the page");
+        },
+
+        test_choicesource_has_no_click: function () {
+            var contentBox = this.choice_edit.get('contentBox');
+            Assert.isTrue(contentBox.hasClass('no-click'),
+                          "no-click not applied to choicelist html.");
         }
-
     }));
 
     /**