Merge lp:~jcsackett/launchpad/missing-results-count-in-chromium into lp:launchpad
Status: | Merged |
---|---|
Approved by: | j.c.sackett |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15951 |
Proposed branch: | lp:~jcsackett/launchpad/missing-results-count-in-chromium |
Merge into: | lp:launchpad |
Prerequisite: | lp:~jcsackett/launchpad/clean-up-buglisting-classes |
Diff against target: |
137 lines (+37/-56) 1 file modified
lib/lp/bugs/javascript/buglisting.js (+37/-56) |
To merge this branch: | bzr merge lp:~jcsackett/launchpad/missing-results-count-in-chromium |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email:
|
Commit message
Fixes display of results count on bug listing in chromium.
Description of the change
Summary
=======
Per bug 984871, the bug listing javascript removed the display of the total
number of results when showing navigation links (i.e. NNNN -> MMMM of $total
results).
This was because while it was passing a total from the BugListingModel into
the template, the total was never explicitly set within the model once passed
in via config, and an undefined result was passed to mustache. I have no idea
how it is that firefox continued to display the results count.
Implementation
==============
Add "total" to the ListingModel's ATTRs. It's already passed in via config, so
the YUI Base initializer magic takes care of everything.
Tests
=====
bin/test -vvct buglisting --layer=YUI
QA
==
Ensure the proper results count is displayed on a buglisting in
chrome/chromium.
LoC
===
This branch is preceeded by one that is -20 LoC, to make space for this fix.
Lint
====
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
Thank you.