Merge lp:~jcsackett/launchpad/lp-for-preview-url into lp:launchpad

Proposed by j.c.sackett
Status: Merged
Approved by: Curtis Hovey
Approved revision: no longer in the source branch.
Merged at revision: 14752
Proposed branch: lp:~jcsackett/launchpad/lp-for-preview-url
Merge into: lp:launchpad
Diff against target: 11 lines (+1/-1)
1 file modified
lib/lp/code/javascript/util.js (+1/-1)
To merge this branch: bzr merge lp:~jcsackett/launchpad/lp-for-preview-url
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+91507@code.launchpad.net

Commit message

[r=sinzui][bug=369750] Updates preview url when creating a branch to include the 'lp:' prefix.

Description of the change

This is a very simple branch; it just address a minor text inconsistency,
adding 'lp:' to the preview url given in +addbranch.

Previously this would say the new branch would be at
"~username/product/branch", not it says "lp:~username/product/branch".

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/javascript/util.js'
2--- lib/lp/code/javascript/util.js 2012-01-17 07:24:43 +0000
3+++ lib/lp/code/javascript/util.js 2012-02-06 15:06:21 +0000
4@@ -16,7 +16,7 @@
5 if (name == '') {
6 name = '<name>';
7 }
8- var branch_name = "~" + owner + "/" + target_name + "/" + name;
9+ var branch_name = "lp:~" + owner + "/" + target_name + "/" + name;
10 unique_name.set('text', branch_name);
11 };
12