Merge lp:~jcsackett/launchpad/launchpad-ids-270310 into lp:launchpad

[j.c.sackett]

[r=gmb][ui=sinzui][bug=270310] Adds launchpad id to the person overview.

Summary
=======
Launchpad id, while displayed in the url and the +edit view (and as part of the login data on the left), isn't actually displayed on a users page. Given that documentation references a "launchpad id" and nothing is called this on the user page, a bug was confirmed to add that to the overview.

Trivially, this branch adds an entry for Launchpad id on the contact portlet.

Demo & QA
=========
Go to launchpad.dev/~mark. An entry of Launchpad id exists with the data "mark".

A screenshot is here: http://people.canonical.com/~jc/images/launchpad-id.png

Lint
====

make lint output:

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/person-portlet-contact-details.pt

[Graham Binns (gmb)]

review: Approve (code)

[Curtis Hovey (sinzui)]

We want to use "Id" (http://en.wikipedia.org/wiki/Id.). I think Launchpad Id should be the first item in the portlet. Everyone has one, but email address will often not show when the user hides them.

I believe that fixing this will escalate other issues. I can see my Launchpad Id, but I cannot change it because the field label is Name. Maybe we can replace name with Launchpad Id (and remove title) from all forms in two weeks.

review: Approve (ui)

[j.c.sackett (jcsackett)]

> We want to use "Id" (http://en.wikipedia.org/wiki/Id.). I think Launchpad Id should be the first item in the portlet. Everyone has one, but email address will often not show when the user hides them.

All taken care of.

> I believe that fixing this will escalate other issues. I can see my Launchpad Id, but I cannot change it because the field label is Name. Maybe we can replace name with Launchpad Id (and remove title) from all forms in two weeks.

Not a bad plan--should I go ahead and file a ticket against that?

=== modified file 'lib/lp/registry/templates/person-portlet-contact-details.pt'
--- lib/lp/registry/templates/person-portlet-contact-details.pt	2010-08-16 13:14:31 +0000
+++ lib/lp/registry/templates/person-portlet-contact-details.pt	2010-11-30 17:01:25 +0000
@@ -10,6 +10,10 @@
   <h2>User information</h2>
 
   <div class="first yui-u">
+    <dl id="launchpad-id">
+        <dt>Launchpad Id:</dt>
+        <dd tal:content="context/name"/>
+    </dl>
     <dl id="email-addresses">
       <dt>Email:
         <a tal:replace="structure overview_menu/editemailaddresses/fmt:icon" />
@@ -47,6 +51,7 @@
       </dd>
     </dl>
 
+
     <dl tal:condition="view/should_show_jabberids_section" id="jabber-ids">
       <dt>Jabber:
         <a tal:replace="structure overview_menu/editjabberids/fmt:icon" />