Merge lp:~jcsackett/launchpad/kill-uses-launchpad-for-650648 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 11675 | ||||
Proposed branch: | lp:~jcsackett/launchpad/kill-uses-launchpad-for-650648 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
683 lines (+66/-424) 10 files modified
lib/lp/registry/browser/distribution.py (+1/-38) lib/lp/registry/browser/product.py (+1/-2) lib/lp/registry/stories/distribution/xx-distribution-launchpad-usage.txt (+8/-33) lib/lp/registry/stories/product/xx-product-launchpad-usage.txt (+0/-223) lib/lp/registry/templates/distribution-details.pt (+0/-11) lib/lp/registry/templates/product-index.pt (+0/-11) lib/lp/translations/stories/project/xx-project-translations.txt (+52/-67) lib/lp/translations/stories/standalone/xx-product-translations.txt (+1/-7) lib/lp/translations/stories/translationgroups/10-distro-translation-group.txt (+3/-9) lib/lp/translations/stories/translationgroups/15-product-translation-group.txt (+0/-23) |
||||
To merge this branch: | bzr merge lp:~jcsackett/launchpad/kill-uses-launchpad-for-650648 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | ui/code | Approve | |
Review via email: mp+37252@code.launchpad.net |
Commit message
Removes the Uses Launchpad for data in the product and distribution overview pages; this information is redundant.
Description of the change
Summary
=======
Removes the "Uses Launchpad for" section on product and distribution, which is superseded by the involvement menu.
Proposed Fix
============
Remove the section in the templates that displays the "Uses Launchpad for" as well as the UsesLaunchpadMixin used by the Views to determine what to display.
Pre-Implementation Talk
=======
Spoke with Curtis.
Implementation details
=======
Largely as in proposed.
Removing the code/template section required updating the tests; in some cases rather than showing the positive condition "Translations is enabled," the only path that conformed to the story structure was instead to show the negative "Translations isn't in the disabled list." In other cases it seemed to make more sense to just remove the section of the test checking what usage showed, since it had more to do with manipulating controls. Comments on the stories are invited--I'm not certain it was the best approach.
Tests
=====
Demo and Q/A
============
The "Uses Launchpad for: " section on product/distros should be gone on all pages.
Lint
====
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Hi Jon.
We talked in IRC. we both agreed that xx-product- launchpad- usage.txt may have lost its raison d'etra. We see lame tests for Product+edit, but +edit has not been used to configure applications for 6 months. We may want to delete the whole test since we know the form is well tested. We only want to keep this test if it explains why a project owner will enable or disable an application to enable/disable Involvement menu links. There is certainly more to delete.