Launchpad itself

Merge lp:~jcsackett/launchpad/kill-lazr-1 into lp:launchpad

  1. kill-lazr-1
  2. Merge into devel
Proposed by j.c.sackett on 2012-08-23
Status: Merged
Approved by: Curtis Hovey on 2012-08-23
Approved revision: no longer in the source branch.
Merged at revision: 15880
Proposed branch: lp:~jcsackett/launchpad/kill-lazr-1
Merge into: lp:launchpad
Diff against target: 902 lines (+94/-99)
46 files modified
buildout-templates/bin/combine-css.in (+1/-1)
lib/lp/answers/javascript/tests/test_answercontacts.html (+1/-1)
lib/lp/answers/javascript/tests/test_subscribers.html (+1/-1)
lib/lp/app/javascript/activator/activator.js (+2/-2)
lib/lp/app/javascript/activator/assets/skins/sam/activator-skin.css (+1/-1)
lib/lp/app/javascript/activator/tests/test_activator.html (+1/-1)
lib/lp/app/javascript/anim/tests/test_anim.html (+1/-1)
lib/lp/app/javascript/choiceedit/choiceedit.js (+2/-3)
lib/lp/app/javascript/choiceedit/tests/test_choiceedit.html (+1/-1)
lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.html (+1/-1)
lib/lp/app/javascript/formoverlay/tests/test_formoverlay.html (+1/-1)
lib/lp/app/javascript/formwidgets/tests/test_formwidgets.html (+1/-1)
lib/lp/app/javascript/inlineedit/assets/skins/sam/editor-skin.css (+2/-2)
lib/lp/app/javascript/inlineedit/editor.js (+5/-5)
lib/lp/app/javascript/inlineedit/tests/test_inline_edit.html (+1/-1)
lib/lp/app/javascript/picker/assets/skins/sam/picker-skin.css (+1/-1)
lib/lp/app/javascript/picker/picker.js (+9/-8)
lib/lp/app/javascript/picker/tests/test_personpicker.html (+1/-1)
lib/lp/app/javascript/picker/tests/test_picker.html (+1/-1)
lib/lp/app/javascript/picker/tests/test_picker.js (+12/-12)
lib/lp/app/javascript/picker/tests/test_picker_patcher.html (+1/-3)
lib/lp/app/javascript/picker/tests/test_team.html (+1/-1)
lib/lp/app/javascript/subscribers/tests/test_subscribers_list.html (+1/-1)
lib/lp/app/javascript/tests/test_multicheckboxwidget.html (+1/-1)
lib/lp/app/javascript/ui/ui.js (+21/-22)
lib/lp/bugs/javascript/bug_tags_entry.js (+1/-2)
lib/lp/bugs/javascript/bugtask_index.js (+2/-2)
lib/lp/bugs/javascript/official_bug_tags.js (+2/-3)
lib/lp/bugs/javascript/tests/test_bug_picker.html (+1/-1)
lib/lp/bugs/javascript/tests/test_bugtask_delete.html (+1/-1)
lib/lp/bugs/javascript/tests/test_duplicates.html (+1/-1)
lib/lp/bugs/javascript/tests/test_information_type_choice.html (+1/-1)
lib/lp/bugs/javascript/tests/test_official_bug_tags.html (+1/-1)
lib/lp/bugs/javascript/tests/test_subscribers.html (+1/-1)
lib/lp/code/javascript/tests/test_branchmergeproposal.nominate.html (+1/-1)
lib/lp/code/javascript/tests/test_branchrevisionexpander.html (+1/-1)
lib/lp/code/javascript/tests/test_bugspeclinks.html (+1/-1)
lib/lp/code/javascript/tests/test_information_type_choice.html (+1/-1)
lib/lp/registry/javascript/distroseries/tests/test_differences.html (+1/-1)
lib/lp/registry/javascript/distroseries/tests/test_initseries.html (+1/-1)
lib/lp/registry/javascript/distroseries/tests/test_widgets.html (+1/-1)
lib/lp/registry/javascript/sharing/tests/test_granteepicker.html (+1/-1)
lib/lp/registry/javascript/sharing/tests/test_granteetable.html (+1/-1)
lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html (+1/-1)
lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.html (+1/-1)
lib/lp/translations/javascript/tests/test_importqueue.html (+1/-1)
To merge this branch: bzr merge lp:~jcsackett/launchpad/kill-lazr-1
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code 2012-08-23 Approve on 2012-08-23
Review via email: mp+121079@code.launchpad.net

Commit Message

Migrates lazr.base to lp.ui

Description of the Change

Summary
=======
As the first part of migrating lazr to a new lp.ui namespace, this moves the
the lazr.base code to lp.ui.

Preimp
======
Spoke with Rick Harding

Implementation
==============
* Moved lib/lp/app/javascript/lazr/lazr.js to lib/lp/app/javascript/ui/ui.js,
  and updated related paths.

* Renamed the lazr.ui namespace to lp.ui and updated callsites.

* Renamed lazr.base module to lp.ui-base module, and updated callsites.

Tests
=====
bin/test -vvc --layer=YUI

QA
==
Make sure javascript is still working across the site. This is a big one.

LoC
===
This removes 5 LoC; truthfully, it's LoC neutral if restricted to meaningful LoC.

Lint
====

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/app/javascript/picker/tests/test_personpicker.html
  lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.html
  lib/lp/registry/javascript/sharing/tests/test_granteetable.html
  lib/lp/bugs/javascript/tests/test_bug_picker.html
  lib/lp/answers/javascript/tests/test_subscribers.html
  lib/lp/app/javascript/picker/tests/test_picker_patcher.html
  lib/lp/app/javascript/choiceedit/tests/test_choiceedit.html
  lib/lp/app/javascript/ui/ui.js
  lib/lp/bugs/javascript/tests/test_official_bug_tags.html
  lib/lp/registry/javascript/distroseries/tests/test_widgets.html
  lib/lp/app/javascript/tests/test_multicheckboxwidget.html
  lib/lp/app/javascript/formwidgets/tests/test_formwidgets.html
  lib/lp/app/javascript/picker/assets/skins/sam/picker-skin.css
  lib/lp/app/javascript/inlineedit/editor.js
  lib/lp/app/javascript/inlineedit/assets/skins/sam/editor-skin.css
  lib/lp/code/javascript/tests/test_bugspeclinks.html
  lib/lp/answers/javascript/tests/test_answercontacts.html
  lib/lp/app/javascript/activator/activator.js
  lib/lp/registry/javascript/distroseries/tests/test_differences.html
  lib/lp/app/javascript/subscribers/tests/test_subscribers_list.html
  lib/lp/app/javascript/picker/tests/test_picker.js
  lib/lp/translations/javascript/tests/test_importqueue.html
  lib/lp/bugs/javascript/bugtask_index.js
  lib/lp/app/javascript/anim/tests/test_anim.html
  lib/lp/registry/javascript/sharing/tests/test_granteepicker.html
  lib/lp/app/javascript/formoverlay/tests/test_formoverlay.html
  lib/lp/app/javascript/choiceedit/choiceedit.js
  lib/lp/registry/javascript/distroseries/tests/test_initseries.html
  lib/lp/bugs/javascript/tests/test_bugtask_delete.html
  lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.html
  lib/lp/code/javascript/tests/test_branchrevisionexpander.html
  lib/lp/app/javascript/picker/picker.js
  lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html
  lib/lp/app/javascript/activator/tests/test_activator.html
  lib/lp/bugs/javascript/tests/test_subscribers.html
  lib/lp/bugs/javascript/bug_tags_entry.js
  lib/lp/bugs/javascript/tests/test_information_type_choice.html
  buildout-templates/bin/combine-css.in
  lib/lp/app/javascript/picker/tests/test_team.html
  lib/lp/app/javascript/picker/tests/test_picker.html
  lib/lp/code/javascript/tests/test_branchmergeproposal.nominate.html
  lib/lp/bugs/javascript/tests/test_duplicates.html
  lib/lp/app/javascript/activator/assets/skins/sam/activator-skin.css
  lib/lp/app/javascript/inlineedit/tests/test_inline_edit.html
  lib/lp/bugs/javascript/official_bug_tags.js

To post a comment you must log in.
Curtis Hovey (sinzui) wrote :

This looks good to land. I see that lib/lp/app/javascript/choiceedit/choiceedit.js and lib/lp/bugs/javascript/bug_tags_entry.js both do not change to "lp.ui-base". Is this because they imported lazr.base, but they did not need to?

review: Approve (code)
j.c.sackett (jcsackett) wrote :

> I see that
> lib/lp/app/javascript/choiceedit/choiceedit.js and
> lib/lp/bugs/javascript/bug_tags_entry.js both do not change to "lp.ui-base".
> Is this because they imported lazr.base, but they did not need to?

Correct; I think at some point they were using lazr.base, but a refactor removed the use. Alternatively, it was just an overzealous "require" statement.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'buildout-templates/bin/combine-css.in'
2--- buildout-templates/bin/combine-css.in 2012-06-02 02:12:21 +0000
3+++ buildout-templates/bin/combine-css.in 2012-08-29 20:50:27 +0000
4@@ -26,7 +26,7 @@
5 # Use the old cssgrids instead of the new cssgrids.
6 #'lazr/build/yui/cssgrids/grids.css',
7 'cssgrids/grids.css',
8- 'build/lazr/assets/skins/sam/lazr.css',
9+ 'build/ui/assets/skins/sam/lazr.css',
10 'build/inlineedit/assets/skins/sam/editor.css',
11 'build/autocomplete/assets/skins/sam/autocomplete.css',
12 'build/overlay/assets/skins/sam/pretty-overlay.css',
13
14=== modified file 'lib/lp/answers/javascript/tests/test_answercontacts.html'
15--- lib/lp/answers/javascript/tests/test_answercontacts.html 2012-03-14 01:50:52 +0000
16+++ lib/lp/answers/javascript/tests/test_answercontacts.html 2012-08-29 20:50:27 +0000
17@@ -35,7 +35,7 @@
18 <script type="text/javascript" src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
19 <script type="text/javascript" src="../../../../../build/js/lp/app/anim/anim.js"></script>
20 <script type="text/javascript" src="../../../../../build/js/lp/app/activator/activator.js"></script>
21- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
22+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
23 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker_patcher.js"></script>
24 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker.js"></script>
25 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/person_picker.js"></script>
26
27=== modified file 'lib/lp/answers/javascript/tests/test_subscribers.html'
28--- lib/lp/answers/javascript/tests/test_subscribers.html 2012-03-14 01:50:52 +0000
29+++ lib/lp/answers/javascript/tests/test_subscribers.html 2012-08-29 20:50:27 +0000
30@@ -35,7 +35,7 @@
31 <script type="text/javascript" src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
32 <script type="text/javascript" src="../../../../../build/js/lp/app/anim/anim.js"></script>
33 <script type="text/javascript" src="../../../../../build/js/lp/app/activator/activator.js"></script>
34- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
35+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
36 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker_patcher.js"></script>
37 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker.js"></script>
38 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/person_picker.js"></script>
39
40=== modified file 'lib/lp/app/javascript/activator/activator.js'
41--- lib/lp/app/javascript/activator/activator.js 2011-08-09 14:18:02 +0000
42+++ lib/lp/app/javascript/activator/activator.js 2012-08-29 20:50:27 +0000
43@@ -274,7 +274,7 @@
44 }
45 });
46
47-Y.lazr.ui.disableTabIndex(Activator);
48+Y.lp.ui.disableTabIndex(Activator);
49
50 Y.namespace('lazr.activator');
51 Y.lazr.activator.Activator = Activator;
52@@ -282,4 +282,4 @@
53
54 }, "0.1", {"skinnable": true,
55 "requires": ["oop", "event", "node", "widget",
56- "lp.anim", "lazr.base"]});
57+ "lp.anim", "lp.ui-base"]});
58
59=== modified file 'lib/lp/app/javascript/activator/assets/skins/sam/activator-skin.css'
60--- lib/lp/app/javascript/activator/assets/skins/sam/activator-skin.css 2011-10-26 02:09:28 +0000
61+++ lib/lp/app/javascript/activator/assets/skins/sam/activator-skin.css 2012-08-29 20:50:27 +0000
62@@ -6,7 +6,7 @@
63 }
64
65 .yui3-skin-sam .yui3-activator-processing button.yui3-activator-act {
66- background: url('../../../../lazr/assets/skins/sam/spinner.gif')
67+ background: url('../../../../ui/assets/skins/sam/spinner.gif')
68 0 0 no-repeat;
69 }
70
71
72=== modified file 'lib/lp/app/javascript/activator/tests/test_activator.html'
73--- lib/lp/app/javascript/activator/tests/test_activator.html 2012-03-14 04:41:36 +0000
74+++ lib/lp/app/javascript/activator/tests/test_activator.html 2012-08-29 20:50:27 +0000
75@@ -26,7 +26,7 @@
76
77 <!-- Dependencies -->
78 <script type="text/javascript" src="../../../../../../build/js/lp/app/anim/anim.js"></script>
79- <script type="text/javascript" src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
80+ <script type="text/javascript" src="../../../../../../build/js/lp/app/ui/ui.js"></script>
81 <script type="text/javascript" src="../../../../../../build/js/lp/app/extras/extras.js"></script>
82
83 <!-- The module under test. -->
84
85=== modified file 'lib/lp/app/javascript/anim/tests/test_anim.html'
86--- lib/lp/app/javascript/anim/tests/test_anim.html 2012-03-14 04:41:36 +0000
87+++ lib/lp/app/javascript/anim/tests/test_anim.html 2012-08-29 20:50:27 +0000
88@@ -26,7 +26,7 @@
89
90 <!-- Dependencies -->
91 <script type="text/javascript" src="../../../../../../build/js/lp/app/extras/extras.js"></script>
92- <script type="text/javascript" src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
93+ <script type="text/javascript" src="../../../../../../build/js/lp/app/ui/ui.js"></script>
94
95 <!-- The module under test. -->
96 <script type="text/javascript" src="../anim.js"></script>
97
98=== modified file 'lib/lp/app/javascript/choiceedit/choiceedit.js'
99--- lib/lp/app/javascript/choiceedit/choiceedit.js 2012-08-16 03:58:39 +0000
100+++ lib/lp/app/javascript/choiceedit/choiceedit.js 2012-08-29 20:50:27 +0000
101@@ -732,8 +732,7 @@
102 },"0.2", {
103 "skinnable": true,
104 "requires": [
105- "oop", "event", "event-delegate", "node", "widget",
106- "widget-position", "widget-stdmod", "overlay", "lazr.overlay",
107- "lp.anim", "lazr.base"]
108+ "oop", "event", "event-delegate", "node", "widget", "widget-position",
109+ "widget-stdmod", "overlay", "lazr.overlay", "lp.anim"]
110 });
111
112
113=== modified file 'lib/lp/app/javascript/choiceedit/tests/test_choiceedit.html'
114--- lib/lp/app/javascript/choiceedit/tests/test_choiceedit.html 2012-08-14 18:38:25 +0000
115+++ lib/lp/app/javascript/choiceedit/tests/test_choiceedit.html 2012-08-29 20:50:27 +0000
116@@ -25,7 +25,7 @@
117 <link rel="stylesheet" href="../../../../app/javascript/testing/test.css" />
118
119 <!-- Dependencies -->
120- <script type="text/javascript" src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
121+ <script type="text/javascript" src="../../../../../../build/js/lp/app/ui/ui.js"></script>
122 <script type="text/javascript" src="../../../../../../build/js/lp/app/anim/anim.js"></script>
123 <script type="text/javascript" src="../../../../../../build/js/lp/app/overlay/overlay.js"></script>
124 <script type="text/javascript" src="../../../../../../build/js/lp/app/extras/extras.js"></script>
125
126=== modified file 'lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.html'
127--- lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.html 2012-03-14 04:41:36 +0000
128+++ lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.html 2012-08-29 20:50:27 +0000
129@@ -25,7 +25,7 @@
130 <link rel="stylesheet" href="../../../../app/javascript/testing/test.css" />
131
132 <!-- Dependencies -->
133- <script type="text/javascript" src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
134+ <script type="text/javascript" src="../../../../../../build/js/lp/app/ui/ui.js"></script>
135 <script type="text/javascript" src="../../../../../../build/js/lp/app/overlay/overlay.js"></script>
136 <script type="text/javascript" src="../../../../../../build/js/lp/app/formoverlay/formoverlay.js"></script>
137
138
139=== modified file 'lib/lp/app/javascript/formoverlay/tests/test_formoverlay.html'
140--- lib/lp/app/javascript/formoverlay/tests/test_formoverlay.html 2012-03-14 04:41:36 +0000
141+++ lib/lp/app/javascript/formoverlay/tests/test_formoverlay.html 2012-08-29 20:50:27 +0000
142@@ -26,7 +26,7 @@
143
144 <!-- Dependencies -->
145 <script type="text/javascript" src="../../../../../../build/js/lp/app/testing/mockio.js"></script>
146- <script type="text/javascript" src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
147+ <script type="text/javascript" src="../../../../../../build/js/lp/app/ui/ui.js"></script>
148 <script type="text/javascript" src="../../../../../../build/js/lp/app/overlay/overlay.js"></script>
149
150 <!-- The module under test. -->
151
152=== modified file 'lib/lp/app/javascript/formwidgets/tests/test_formwidgets.html'
153--- lib/lp/app/javascript/formwidgets/tests/test_formwidgets.html 2012-03-14 04:41:36 +0000
154+++ lib/lp/app/javascript/formwidgets/tests/test_formwidgets.html 2012-08-29 20:50:27 +0000
155@@ -28,7 +28,7 @@
156 <script type="text/javascript" src="../../../../../../build/js/lp/app/client.js"></script>
157 <script type="text/javascript" src="../../../../../../build/js/lp/app/activator/activator.js"></script>
158 <script type="text/javascript" src="../../../../../../build/js/lp/app/anim/anim.js"></script>
159- <script type="text/javascript" src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
160+ <script type="text/javascript" src="../../../../../../build/js/lp/app/ui/ui.js"></script>
161 <script type="text/javascript" src="../../../../../../build/js/lp/app/overlay/overlay.js"></script>
162 <script type="text/javascript" src="../../../../../../build/js/lp/app/extras/extras.js"></script>
163
164
165=== modified file 'lib/lp/app/javascript/inlineedit/assets/skins/sam/editor-skin.css'
166--- lib/lp/app/javascript/inlineedit/assets/skins/sam/editor-skin.css 2011-12-08 20:31:53 +0000
167+++ lib/lp/app/javascript/inlineedit/assets/skins/sam/editor-skin.css 2012-08-29 20:50:27 +0000
168@@ -74,7 +74,7 @@
169 }
170
171 .yui3-skin-sam .yui3-ieditor-waiting .yui3-ieditor-btns {
172- background: url("../../../../lazr/assets/skins/sam/spinner.gif") 0.2em 0em no-repeat;
173+ background: url("../../../../ui/assets/skins/sam/spinner.gif") 0.2em 0em no-repeat;
174 }
175
176 /*
177@@ -192,7 +192,7 @@
178 position: relative;
179 top: 4px;
180 left: -8px;
181- background: url('../../../../lazr/assets/skins/sam/spinner.gif') top left no-repeat;
182+ background: url('../../../../ui/assets/skins/sam/spinner.gif') top left no-repeat;
183 padding: 2px 0 0 18px;
184 z-index: 2;
185 }
186
187=== modified file 'lib/lp/app/javascript/inlineedit/editor.js'
188--- lib/lp/app/javascript/inlineedit/editor.js 2012-08-13 04:01:52 +0000
189+++ lib/lp/app/javascript/inlineedit/editor.js 2012-08-29 20:50:27 +0000
190@@ -93,7 +93,7 @@
191 * @type string
192 * @static
193 */
194-InlineEditor.SUBMIT_TEMPLATE = Y.lazr.ui.OK_BUTTON;
195+InlineEditor.SUBMIT_TEMPLATE = Y.lp.ui.OK_BUTTON;
196
197 /**
198 * Static html template to use for creating the 'Cancel' button.
199@@ -102,7 +102,7 @@
200 * @type string
201 * @static
202 */
203-InlineEditor.CANCEL_TEMPLATE = Y.lazr.ui.CANCEL_BUTTON;
204+InlineEditor.CANCEL_TEMPLATE = Y.lp.ui.CANCEL_BUTTON;
205
206 /**
207 * Static html template to use for creating the editor's <input> field.
208@@ -892,7 +892,7 @@
209
210 });
211
212-Y.lazr.ui.disableTabIndex(InlineEditor);
213+Y.lp.ui.disableTabIndex(InlineEditor);
214
215 Y.InlineEditor = InlineEditor;
216
217@@ -1419,12 +1419,12 @@
218 }
219 });
220
221-Y.lazr.ui.disableTabIndex(EditableText);
222+Y.lp.ui.disableTabIndex(EditableText);
223
224 Y.EditableText = EditableText;
225
226 }, "0.2", {"skinnable": true,
227 "requires": ["oop", "anim", "event", "node", "widget",
228- "lp.anim", "lazr.base", "lp.app.errors",
229+ "lp.anim", "lp.ui-base", "lp.app.errors",
230 "lp.app.formwidgets.resizing_textarea",
231 "lp.app.ellipsis"]});
232
233=== modified file 'lib/lp/app/javascript/inlineedit/tests/test_inline_edit.html'
234--- lib/lp/app/javascript/inlineedit/tests/test_inline_edit.html 2012-08-13 06:09:54 +0000
235+++ lib/lp/app/javascript/inlineedit/tests/test_inline_edit.html 2012-08-29 20:50:27 +0000
236@@ -36,7 +36,7 @@
237 <script type="text/javascript"
238 src="../../../../../../build/js/lp/app/overlay/overlay.js"></script>
239 <script type="text/javascript"
240- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
241+ src="../../../../../../build/js/lp/app/ui/ui.js"></script>
242 <script type="text/javascript"
243 src="../../../../../../build/js/lp/app/extras/extras.js"></script>
244 <script type="text/javascript"
245
246=== modified file 'lib/lp/app/javascript/picker/assets/skins/sam/picker-skin.css'
247--- lib/lp/app/javascript/picker/assets/skins/sam/picker-skin.css 2011-06-29 14:56:15 +0000
248+++ lib/lp/app/javascript/picker/assets/skins/sam/picker-skin.css 2012-08-29 20:50:27 +0000
249@@ -25,7 +25,7 @@
250 }
251
252 .yui3-picker-search-mode button.lazr-search {
253- background: url('../../../../lazr/assets/skins/sam/spinner.gif')
254+ background: url('../../../../ui/assets/skins/sam/spinner.gif')
255 0.2em 0 no-repeat;
256 }
257
258
259=== modified file 'lib/lp/app/javascript/picker/picker.js'
260--- lib/lp/app/javascript/picker/picker.js 2012-08-08 11:59:48 +0000
261+++ lib/lp/app/javascript/picker/picker.js 2012-08-29 20:50:27 +0000
262@@ -244,7 +244,7 @@
263
264 // The enabled property of the prev/next buttons is controlled
265 // in _syncSelectedBatchUI.
266- this._prev_button = Y.Node.create(Y.lazr.ui.PREVIOUS_BUTTON);
267+ this._prev_button = Y.Node.create(Y.lp.ui.PREVIOUS_BUTTON);
268 this._prev_button.on('click', function (e) {
269 var selected = this.get('selected_batch') - 1;
270 this.set('selected_batch', selected);
271@@ -267,7 +267,7 @@
272 }, this);
273 }, this);
274
275- this._next_button = Y.Node.create(Y.lazr.ui.NEXT_BUTTON);
276+ this._next_button = Y.Node.create(Y.lp.ui.NEXT_BUTTON);
277 this._batches_box.appendChild(this._next_button);
278 this._next_button.on('click', function (e) {
279 var selected = this.get('selected_batch') + 1;
280@@ -511,7 +511,7 @@
281 var li_details = this._renderDetailsUI(data);
282 // Put the list item together.
283 var li = Y.Node.create('<li></li>').addClass(
284- i % 2 ? Y.lazr.ui.CSS_ODD : Y.lazr.ui.CSS_EVEN);
285+ i % 2 ? Y.lp.ui.CSS_ODD : Y.lp.ui.CSS_EVEN);
286 if (data.css) {
287 li.addClass(data.css);
288 }
289@@ -687,7 +687,7 @@
290 * @method renderUI
291 */
292 renderUI: function() {
293- this._search_button = Y.Node.create(Y.lazr.ui.SEARCH_BUTTON);
294+ this._search_button = Y.Node.create(Y.lp.ui.SEARCH_BUTTON);
295
296 var search_box = Y.Node.create([
297 '<div>',
298@@ -1315,8 +1315,9 @@
299 ns.TextFieldPickerPlugin = TextFieldPickerPlugin;
300
301 }, "0.1", {"skinnable": true,
302- "requires": ["oop", "escape", "event", "event-focus", "base", "node",
303- "plugin", "substitute", "widget", "widget-stdmod",
304- "lazr.overlay", "lp.anim", "lazr.base",
305- "lp.app.widgets.expander"]
306+ "requires":
307+ ["oop", "escape", "event", "event-focus", "base", "node",
308+ "plugin", "substitute", "widget", "widget-stdmod",
309+ "lazr.overlay", "lp.anim", "lp.ui-base",
310+ "lp.app.widgets.expander"]
311 });
312
313=== modified file 'lib/lp/app/javascript/picker/tests/test_personpicker.html'
314--- lib/lp/app/javascript/picker/tests/test_personpicker.html 2012-07-03 07:11:22 +0000
315+++ lib/lp/app/javascript/picker/tests/test_personpicker.html 2012-08-29 20:50:27 +0000
316@@ -36,7 +36,7 @@
317 <script type="text/javascript"
318 src="../../../../../../build/js/lp/app/anim/anim.js"></script>
319 <script type="text/javascript"
320- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
321+ src="../../../../../../build/js/lp/app/ui/ui.js"></script>
322 <script type="text/javascript"
323 src="../../../../../../build/js/lp/app/overlay/overlay.js"></script>
324 <script type="text/javascript"
325
326=== modified file 'lib/lp/app/javascript/picker/tests/test_picker.html'
327--- lib/lp/app/javascript/picker/tests/test_picker.html 2012-03-14 04:41:36 +0000
328+++ lib/lp/app/javascript/picker/tests/test_picker.html 2012-08-29 20:50:27 +0000
329@@ -36,7 +36,7 @@
330 <script type="text/javascript"
331 src="../../../../../../build/js/lp/app/effects/effects.js"></script>
332 <script type="text/javascript"
333- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
334+ src="../../../../../../build/js/lp/app/ui/ui.js"></script>
335 <script type="text/javascript"
336 src="../../../../../../build/js/lp/app/extras/extras.js"></script>
337
338
339=== modified file 'lib/lp/app/javascript/picker/tests/test_picker.js'
340--- lib/lp/app/javascript/picker/tests/test_picker.js 2012-04-06 17:28:25 +0000
341+++ lib/lp/app/javascript/picker/tests/test_picker.js 2012-08-29 20:50:27 +0000
342@@ -92,7 +92,7 @@
343
344 test_set_results_updates_display: function () {
345 this.picker.render();
346- var image_url = '../../lazr/assets/skins/sam/search.png';
347+ var image_url = '../../ui/assets/skins/sam/search.png';
348 this.picker.set('results', [
349 {
350 image: image_url,
351@@ -337,13 +337,13 @@
352 this.picker.render();
353 var badge_info = [
354 {
355- url: '../../lazr/assets/skins/sam/search.png',
356+ url: '../../ui/assets/skins/sam/search.png',
357 label: 'product 1',
358 role: 'driver'},
359- { url: '../../lazr/assets/skins/sam/spinner.png',
360+ { url: '../../ui/assets/skins/sam/spinner.png',
361 label: 'product 2',
362 role: 'maintainer'},
363- { url: '../../lazr/assets/skins/sam/spinner.png',
364+ { url: '../../ui/assets/skins/sam/spinner.png',
365 label: 'product 2',
366 role: 'driver'
367 }];
368@@ -383,11 +383,11 @@
369 this.picker.render();
370 var badge_info = [
371 {
372- url: '../../lazr/assets/skins/sam/spinner.png',
373+ url: '../../ui/assets/skins/sam/spinner.png',
374 label: 'product 1',
375 role: 'maintainer'},
376 {
377- url: '../../lazr/assets/skins/sam/search.png',
378+ url: '../../ui/assets/skins/sam/search.png',
379 label: 'product 2',
380 role: 'driver'}];
381 this.picker.set('results', [
382@@ -408,13 +408,13 @@
383 var badge_img = affiliation_header.one('img');
384 Assert.areEqual('product 1 maintainer', badge_img.get('alt'));
385 Assert.areEqual(
386- '../../lazr/assets/skins/sam/spinner.png',
387+ '../../ui/assets/skins/sam/spinner.png',
388 badge_img.getAttribute('src'));
389 affiliation_header = details.one('div.affiliation:nth-child(3)');
390 badge_img = affiliation_header.one('img');
391 Assert.areEqual('product 2 driver', badge_img.get('alt'));
392 Assert.areEqual(
393- '../../lazr/assets/skins/sam/search.png',
394+ '../../ui/assets/skins/sam/search.png',
395 badge_img.getAttribute('src'));
396 var affiliation_text = details.one(
397 'div.affiliation-text:nth-child(2)');
398@@ -455,14 +455,14 @@
399
400 test_results_updates_display_with_missing_data: function () {
401 this.picker.render();
402- var image_url = '../../lazr/assets/skins/sam/search.png';
403+ var image_url = '../../ui/assets/skins/sam/search.png';
404 this.picker.set('results', [
405 { value: 'jschmo', title: 'Joe Schmo' }
406 ]);
407 var bb = this.picker.get('boundingBox');
408 var li = bb.one('.yui3-picker-results li');
409 Assert.isNotNull(li, "Results not found.");
410- Assert.areEqual(Y.lazr.ui.CSS_EVEN, li.getAttribute('class'));
411+ Assert.areEqual(Y.lp.ui.CSS_EVEN, li.getAttribute('class'));
412 Assert.isNull(li.one('img'), "Unexpected image.");
413 var description_el = li.one('.yui3-picker-result-description.');
414 Assert.isNull(description_el, "Unexpected description element.");
415@@ -515,10 +515,10 @@
416 Assert.isNotNull(results, "Results not found.");
417 ArrayAssert.itemsAreEqual(
418 [true, false, true, false],
419- results.hasClass(Y.lazr.ui.CSS_EVEN));
420+ results.hasClass(Y.lp.ui.CSS_EVEN));
421 ArrayAssert.itemsAreEqual(
422 [false, true, false, true],
423- results.hasClass(Y.lazr.ui.CSS_ODD));
424+ results.hasClass(Y.lp.ui.CSS_ODD));
425 },
426
427 test_clicking_search_button_fires_search_event: function () {
428
429=== modified file 'lib/lp/app/javascript/picker/tests/test_picker_patcher.html'
430--- lib/lp/app/javascript/picker/tests/test_picker_patcher.html 2012-04-25 18:17:08 +0000
431+++ lib/lp/app/javascript/picker/tests/test_picker_patcher.html 2012-08-29 20:50:27 +0000
432@@ -34,12 +34,10 @@
433 <script type="text/javascript"
434 src="../../../../../../build/js/lp/app/anim/anim.js"></script>
435 <script type="text/javascript"
436- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
437+ src="../../../../../../build/js/lp/app/ui/ui.js"></script>
438 <script type="text/javascript"
439 src="../../../../../../build/js/lp/app/client.js"></script>
440 <script type="text/javascript"
441- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
442- <script type="text/javascript"
443 src="../../../../../../build/js/lp/app/picker/picker.js"></script>
444 <script type="text/javascript"
445 src="../../../../../../build/js/lp/app/picker/person_picker.js"></script>
446
447=== modified file 'lib/lp/app/javascript/picker/tests/test_team.html'
448--- lib/lp/app/javascript/picker/tests/test_team.html 2012-07-03 01:18:52 +0000
449+++ lib/lp/app/javascript/picker/tests/test_team.html 2012-08-29 20:50:27 +0000
450@@ -34,7 +34,7 @@
451 <script type="text/javascript"
452 src="../../../../../../build/js/lp/app/lp.js"></script>
453 <script type="text/javascript"
454- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
455+ src="../../../../../../build/js/lp/app/ui/ui.js"></script>
456 <script type="text/javascript"
457 src="../../../../../../build/js/lp/app/choiceedit/choiceedit.js"></script>
458 <script type="text/javascript"
459
460=== modified file 'lib/lp/app/javascript/subscribers/tests/test_subscribers_list.html'
461--- lib/lp/app/javascript/subscribers/tests/test_subscribers_list.html 2012-03-14 04:41:36 +0000
462+++ lib/lp/app/javascript/subscribers/tests/test_subscribers_list.html 2012-08-29 20:50:27 +0000
463@@ -42,7 +42,7 @@
464 <script type="text/javascript"
465 src="../../../../../../build/js/lp/app/overlay/overlay.js"></script>
466 <script type="text/javascript"
467- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
468+ src="../../../../../../build/js/lp/app/ui/ui.js"></script>
469 <script type="text/javascript"
470 src="../../../../../../build/js/lp/app/picker/picker.js"></script>
471 <script type="text/javascript"
472
473=== modified file 'lib/lp/app/javascript/tests/test_multicheckboxwidget.html'
474--- lib/lp/app/javascript/tests/test_multicheckboxwidget.html 2012-04-25 18:47:37 +0000
475+++ lib/lp/app/javascript/tests/test_multicheckboxwidget.html 2012-08-29 20:50:27 +0000
476@@ -27,7 +27,7 @@
477 <!-- Dependencies -->
478 <script type="text/javascript" src="../../../../../build/js/lp/app/client.js"></script>
479 <script type="text/javascript" src="../../../../../build/js/lp/app/activator/activator.js"></script>
480- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
481+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
482 <script type="text/javascript" src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
483
484 <!-- The module under test. -->
485
486=== renamed directory 'lib/lp/app/javascript/lazr' => 'lib/lp/app/javascript/ui'
487=== renamed file 'lib/lp/app/javascript/lazr/lazr.js' => 'lib/lp/app/javascript/ui/ui.js'
488--- lib/lp/app/javascript/lazr/lazr.js 2011-07-05 14:30:42 +0000
489+++ lib/lp/app/javascript/ui/ui.js 2012-08-29 20:50:27 +0000
490@@ -1,72 +1,71 @@
491 /* Copyright (c) 2009, Canonical Ltd. All rights reserved. */
492
493-YUI.add('lazr.base', function(Y) {
494-
495-var UI = Y.namespace('lazr.ui');
496-
497-var LAZR = 'lazr';
498+YUI.add('lp.ui-base', function(Y) {
499+
500+var UI = Y.namespace('lp.ui');
501+
502 var getCN = Y.ClassNameManager.getClassName;
503
504 /**
505- * The LAZR standard 'positive' glyph as an HTML button template. Used for
506+ * The standard 'positive' glyph as an HTML button template. Used for
507 * "Ok" buttons, confirmations, etc. It uses an image sprite for the icon.
508 *
509 * The button's default text is "Ok", and its default type is 'button'.
510 * http://www.w3.org/TR/html4/interact/forms.html#h-17.5
511 *
512- * @property lazr.ui.OK_BUTTON
513+ * @property lp.ui.OK_BUTTON
514 * @type String
515 * @static
516 */
517 UI.OK_BUTTON = '<button type="button" class="lazr-pos lazr-btn">Ok</button>';
518
519 /**
520- * The LAZR standard 'negative' glyph as an HTML button template. Used for
521+ * The standard 'negative' glyph as an HTML button template. Used for
522 * "Cancel" buttons, etc. It uses an image sprite for the icon.
523 *
524 * The button's default text is "Cancel", and its default type is 'button'.
525 * http://www.w3.org/TR/html4/interact/forms.html#h-17.5
526 *
527- * @property lazr.ui.CANCEL_BUTTON
528+ * @property lp.ui.CANCEL_BUTTON
529 * @type String
530 * @static
531 */
532 UI.CANCEL_BUTTON = '<button type="button" class="lazr-neg lazr-btn">Cancel</button>';
533
534 /**
535- * The LAZR standard 'search' glyph as an HTML button template. Used for
536+ * The standard 'search' glyph as an HTML button template. Used for
537 * "Search" buttons, etc. It uses an image sprite for the icon.
538 *
539 * The button's default text is "Search", and its default type is 'button'.
540 * http://www.w3.org/TR/html4/interact/forms.html#h-17.5
541 *
542- * @property lazr.ui.SEARCH_BUTTON
543+ * @property lp.ui.SEARCH_BUTTON
544 * @type String
545 * @static
546 */
547 UI.SEARCH_BUTTON = '<button type="button" class="lazr-search lazr-btn">Search</button>';
548
549 /**
550- * The LAZR standard 'previous' glyph as an HTML button template. Used for
551+ * The standard 'previous' glyph as an HTML button template. Used for
552 * "previous"-type buttons. It uses an image sprite for the icon.
553 *
554 * The button's default text is "Previous", and its default type is 'button'.
555 * http://www.w3.org/TR/html4/interact/forms.html#h-17.5
556 *
557- * @property lazr.ui.PREVIOUS_BUTTON
558+ * @property lp.ui.PREVIOUS_BUTTON
559 * @type String
560 * @static
561 */
562 UI.PREVIOUS_BUTTON = '<button type="button" class="lazr-prev lazr-btn">Previous</button>';
563
564 /**
565- * The LAZR standard 'next' glyph as an HTML button template. Used for
566+ * The standard 'next' glyph as an HTML button template. Used for
567 * "next"-type buttons. It uses an image sprite for the icon.
568 *
569 * The button's default text is "Next", and its default type is 'button'.
570 * http://www.w3.org/TR/html4/interact/forms.html#h-17.5
571 *
572- * @property lazr.ui.NEXT_BUTTON
573+ * @property lp.ui.NEXT_BUTTON
574 * @type String
575 * @static
576 */
577@@ -75,20 +74,20 @@
578 /**
579 * Standard CSS class for even elements in a listing.
580 *
581- * @property lazr.ui.CSS_EVEN
582+ * @property lp.ui.CSS_EVEN
583 * @type String
584 * @static
585 */
586-UI.CSS_EVEN = getCN(LAZR, 'even');
587+UI.CSS_EVEN = getCN('lazr', 'even');
588
589 /**
590 * Standard CSS class for odd elements in a listing.
591 *
592- * @property lazr.ui.CSS_ODD
593+ * @property lp.ui.CSS_ODD
594 * @type String
595 * @static
596 */
597-UI.CSS_ODD = getCN(LAZR, 'odd');
598+UI.CSS_ODD = getCN('lazr', 'odd');
599
600 /**
601 * This function forces a class to have a tabIndex attribute which
602@@ -116,14 +115,14 @@
603 /**
604 * Standard class for the UI 'waiting for new content' indicator.
605 *
606- * @property lazr.ui.CSS_WAITING
607+ * @property lp.ui.CSS_WAITING
608 * @type String
609 * @static
610 */
611 UI.CSS_WAITING = 'lazr-waiting';
612
613 /**
614- * This function sets the lazr 'waiting' CSS class on the given node.
615+ * This function sets the 'waiting' CSS class on the given node.
616 *
617 * @method waiting
618 * @param node {Node} The node to apply the CSS 'waiting' class to.
619@@ -134,7 +133,7 @@
620 };
621
622 /**
623- * Clears the lazr 'waiting' CSS class from the given node.
624+ * Clears the 'waiting' CSS class from the given node.
625 *
626 * @method clear_waiting
627 * @param node {Node} The node to remove the class from.
628
629=== modified file 'lib/lp/bugs/javascript/bug_tags_entry.js'
630--- lib/lp/bugs/javascript/bug_tags_entry.js 2012-07-20 21:47:45 +0000
631+++ lib/lp/bugs/javascript/bug_tags_entry.js 2012-08-29 20:50:27 +0000
632@@ -279,6 +279,5 @@
633 }, "0.1", {
634 "requires": [
635 "array-extras", "base", "io-base", "node", "substitute",
636- "node-menunav", "lazr.base", "lp.anim", "lazr.autocomplete",
637- "lp.client"]
638+ "node-menunav", "lp.anim", "lazr.autocomplete", "lp.client"]
639 });
640
641=== modified file 'lib/lp/bugs/javascript/bugtask_index.js'
642--- lib/lp/bugs/javascript/bugtask_index.js 2012-08-08 11:59:48 +0000
643+++ lib/lp/bugs/javascript/bugtask_index.js 2012-08-29 20:50:27 +0000
644@@ -1122,8 +1122,8 @@
645
646 }, "0.1", {"requires": ["base", "oop", "node", "event", "io-base",
647 "json-parse", "substitute",
648- "lazr.formoverlay", "lp.anim", "lazr.base",
649- "lazr.overlay", "lazr.choiceedit", "lp.app.picker",
650+ "lazr.formoverlay", "lp.anim", "lazr.overlay",
651+ "lazr.choiceedit", "lp.app.picker",
652 "lp.bugs.bugtask_index.portlets.subscription",
653 "lp.bugs.information_type_choice",
654 "lp.app.widgets.expander", "lp.client", "escape",
655
656=== modified file 'lib/lp/bugs/javascript/official_bug_tags.js'
657--- lib/lp/bugs/javascript/official_bug_tags.js 2012-07-05 16:13:56 +0000
658+++ lib/lp/bugs/javascript/official_bug_tags.js 2012-08-29 20:50:27 +0000
659@@ -432,7 +432,6 @@
660 Y.one('form[name="launchpadform"]').setStyle('display', 'none');
661 };
662 }, "0.1", {
663- "requires": [
664- "array-extras", "node", "substitute", "base",
665- "collection", "lazr.base", "lazr.overlay"]
666+ "requires": ["array-extras", "node", "substitute", "base", "collection",
667+ "lazr.overlay"]
668 });
669
670=== modified file 'lib/lp/bugs/javascript/tests/test_bug_picker.html'
671--- lib/lp/bugs/javascript/tests/test_bug_picker.html 2012-08-02 09:04:27 +0000
672+++ lib/lp/bugs/javascript/tests/test_bug_picker.html 2012-08-29 20:50:27 +0000
673@@ -41,7 +41,7 @@
674 <script type="text/javascript" src="../../../../../build/js/lp/app/formoverlay/formoverlay.js"></script>
675 <script type="text/javascript" src="../../../../../build/js/lp/app/formwidgets/formwidgets.js"></script>
676 <script type="text/javascript" src="../../../../../build/js/lp/app/inlineedit/editor.js"></script>
677- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
678+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
679 <script type="text/javascript" src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
680 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker.js"></script>
681
682
683=== modified file 'lib/lp/bugs/javascript/tests/test_bugtask_delete.html'
684--- lib/lp/bugs/javascript/tests/test_bugtask_delete.html 2012-07-23 11:15:20 +0000
685+++ lib/lp/bugs/javascript/tests/test_bugtask_delete.html 2012-08-29 20:50:27 +0000
686@@ -41,7 +41,7 @@
687 <script type="text/javascript" src="../../../../../build/js/lp/app/extras/extras.js"></script>
688 <script type="text/javascript" src="../../../../../build/js/lp/app/formoverlay/formoverlay.js"></script>
689 <script type="text/javascript" src="../../../../../build/js/lp/app/inlineedit/editor.js"></script>
690- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
691+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
692 <script type="text/javascript" src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
693 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker.js"></script>
694 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker_patcher.js"></script>
695
696=== modified file 'lib/lp/bugs/javascript/tests/test_duplicates.html'
697--- lib/lp/bugs/javascript/tests/test_duplicates.html 2012-08-08 12:38:30 +0000
698+++ lib/lp/bugs/javascript/tests/test_duplicates.html 2012-08-29 20:50:27 +0000
699@@ -40,7 +40,7 @@
700 <script type="text/javascript" src="../../../../../build/js/lp/app/formoverlay/formoverlay.js"></script>
701 <script type="text/javascript" src="../../../../../build/js/lp/app/formwidgets/formwidgets.js"></script>
702 <script type="text/javascript" src="../../../../../build/js/lp/app/inlineedit/editor.js"></script>
703- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
704+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
705 <script type="text/javascript" src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
706 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker.js"></script>
707 <script type="text/javascript" src="../../../../../build/js/lp/bugs/bug_picker.js"></script>
708
709=== modified file 'lib/lp/bugs/javascript/tests/test_information_type_choice.html'
710--- lib/lp/bugs/javascript/tests/test_information_type_choice.html 2012-08-28 01:52:34 +0000
711+++ lib/lp/bugs/javascript/tests/test_information_type_choice.html 2012-08-29 20:50:27 +0000
712@@ -48,7 +48,7 @@
713 <script type="text/javascript"
714 src="../../../../../build/js/lp/app/inlineedit/editor.js"></script>
715 <script type="text/javascript"
716- src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
717+ src="../../../../../build/js/lp/app/ui/ui.js"></script>
718 <script type="text/javascript"
719 src="../../../../../build/js/lp/app/mustache.js"></script>
720 <script type="text/javascript"
721
722=== modified file 'lib/lp/bugs/javascript/tests/test_official_bug_tags.html'
723--- lib/lp/bugs/javascript/tests/test_official_bug_tags.html 2012-04-26 19:11:37 +0000
724+++ lib/lp/bugs/javascript/tests/test_official_bug_tags.html 2012-08-29 20:50:27 +0000
725@@ -29,7 +29,7 @@
726 <script type="text/javascript" src="../../../../../build/js/yui/collection/collection.js"></script>
727 <script type="text/javascript" src="../../../../../build/js/yui/collection/array-extras.js"></script>
728 <script type="text/javascript" src="../../../../../build/js/yui/substitute/substitute.js"></script>
729- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
730+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
731 <script type="text/javascript" src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
732
733 <!-- The module under test. -->
734
735=== modified file 'lib/lp/bugs/javascript/tests/test_subscribers.html'
736--- lib/lp/bugs/javascript/tests/test_subscribers.html 2012-03-14 04:41:36 +0000
737+++ lib/lp/bugs/javascript/tests/test_subscribers.html 2012-08-29 20:50:27 +0000
738@@ -40,7 +40,7 @@
739 <script type="text/javascript"
740 src="../../../../../build/js/lp/app/formoverlay/formoverlay.js"></script>
741 <script type="text/javascript"
742- src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
743+ src="../../../../../build/js/lp/app/ui/ui.js"></script>
744 <script type="text/javascript"
745 src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
746 <script type="text/javascript"
747
748=== modified file 'lib/lp/code/javascript/tests/test_branchmergeproposal.nominate.html'
749--- lib/lp/code/javascript/tests/test_branchmergeproposal.nominate.html 2012-03-14 04:41:36 +0000
750+++ lib/lp/code/javascript/tests/test_branchmergeproposal.nominate.html 2012-08-29 20:50:27 +0000
751@@ -37,7 +37,7 @@
752 <script type="text/javascript" src="../../../../../build/js/lp/app/extras/extras.js"></script>
753 <script type="text/javascript" src="../../../../../build/js/lp/app/formoverlay/formoverlay.js"></script>
754 <script type="text/javascript" src="../../../../../build/js/lp/app/inlineedit/editor.js"></script>
755- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
756+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
757 <script type="text/javascript" src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
758 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker.js"></script>
759 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker_patcher.js"></script>
760
761=== modified file 'lib/lp/code/javascript/tests/test_branchrevisionexpander.html'
762--- lib/lp/code/javascript/tests/test_branchrevisionexpander.html 2012-07-02 13:09:54 +0000
763+++ lib/lp/code/javascript/tests/test_branchrevisionexpander.html 2012-08-29 20:50:27 +0000
764@@ -26,7 +26,7 @@
765
766 <!-- Dependencies -->
767 <script type="text/javascript" src="../../../../../build/js/lp/app/client.js"></script>
768- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
769+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
770
771 <link rel="stylesheet"
772 href="../../../../canonical/launchpad/icing/lazr/assets/skins/sam/lazr.css" />
773
774=== modified file 'lib/lp/code/javascript/tests/test_bugspeclinks.html'
775--- lib/lp/code/javascript/tests/test_bugspeclinks.html 2012-08-07 05:00:15 +0000
776+++ lib/lp/code/javascript/tests/test_bugspeclinks.html 2012-08-29 20:50:27 +0000
777@@ -38,7 +38,7 @@
778 <script type="text/javascript" src="../../../../../build/js/lp/app/formoverlay/formoverlay.js"></script>
779 <script type="text/javascript" src="../../../../../build/js/lp/app/formwidgets/formwidgets.js"></script>
780 <script type="text/javascript" src="../../../../../build/js/lp/app/inlineedit/editor.js"></script>
781- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
782+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
783 <script type="text/javascript" src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
784 <script type="text/javascript" src="../../../../../build/js/lp/app/picker/picker.js"></script>
785 <script type="text/javascript" src="../../../../../build/js/lp/bugs/bug_picker.js"></script>
786
787=== modified file 'lib/lp/code/javascript/tests/test_information_type_choice.html'
788--- lib/lp/code/javascript/tests/test_information_type_choice.html 2012-08-28 01:52:34 +0000
789+++ lib/lp/code/javascript/tests/test_information_type_choice.html 2012-08-29 20:50:27 +0000
790@@ -44,7 +44,7 @@
791 <script type="text/javascript"
792 src="../../../../../build/js/lp/app/effects/effects.js"></script>
793 <script type="text/javascript"
794- src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
795+ src="../../../../../build/js/lp/app/ui/ui.js"></script>
796 <script type="text/javascript"
797 src="../../../../../build/js/lp/app/choiceedit/choiceedit.js"></script>
798 <script type="text/javascript"
799
800=== modified file 'lib/lp/registry/javascript/distroseries/tests/test_differences.html'
801--- lib/lp/registry/javascript/distroseries/tests/test_differences.html 2012-03-14 04:41:36 +0000
802+++ lib/lp/registry/javascript/distroseries/tests/test_differences.html 2012-08-29 20:50:27 +0000
803@@ -18,7 +18,7 @@
804 <script type="text/javascript"
805 src="../../../../app/javascript/anim/anim.js"></script>
806 <script type="text/javascript"
807- src="../../../../app/javascript/lazr/lazr.js"></script>
808+ src="../../../../app/javascript/ui/ui.js"></script>
809 <script type="text/javascript"
810 src="../../../../app/javascript/overlay/overlay.js"></script>
811 <script type="text/javascript"
812
813=== modified file 'lib/lp/registry/javascript/distroseries/tests/test_initseries.html'
814--- lib/lp/registry/javascript/distroseries/tests/test_initseries.html 2012-07-07 14:00:30 +0000
815+++ lib/lp/registry/javascript/distroseries/tests/test_initseries.html 2012-08-29 20:50:27 +0000
816@@ -18,7 +18,7 @@
817 <script type="text/javascript"
818 src="../../../../app/javascript/anim/anim.js"></script>
819 <script type="text/javascript"
820- src="../../../../app/javascript/lazr/lazr.js"></script>
821+ src="../../../../app/javascript/ui/ui.js"></script>
822 <script type="text/javascript"
823 src="../../../../app/javascript/overlay/overlay.js"></script>
824 <script type="text/javascript"
825
826=== modified file 'lib/lp/registry/javascript/distroseries/tests/test_widgets.html'
827--- lib/lp/registry/javascript/distroseries/tests/test_widgets.html 2012-03-14 04:41:36 +0000
828+++ lib/lp/registry/javascript/distroseries/tests/test_widgets.html 2012-08-29 20:50:27 +0000
829@@ -18,7 +18,7 @@
830 <script type="text/javascript"
831 src="../../../../app/javascript/anim/anim.js"></script>
832 <script type="text/javascript"
833- src="../../../../app/javascript/lazr/lazr.js"></script>
834+ src="../../../../app/javascript/ui/ui.js"></script>
835 <script type="text/javascript"
836 src="../../../../app/javascript/overlay/overlay.js"></script>
837 <script type="text/javascript"
838
839=== modified file 'lib/lp/registry/javascript/sharing/tests/test_granteepicker.html'
840--- lib/lp/registry/javascript/sharing/tests/test_granteepicker.html 2012-07-20 03:15:04 +0000
841+++ lib/lp/registry/javascript/sharing/tests/test_granteepicker.html 2012-08-29 20:50:27 +0000
842@@ -48,7 +48,7 @@
843 <script type="text/javascript"
844 src="../../../../../../build/js/lp/app/effects/effects.js"></script>
845 <script type="text/javascript"
846- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
847+ src="../../../../../../build/js/lp/app/ui/ui.js"></script>
848 <script type="text/javascript"
849 src="../../../../../../build/js/lp/app/extras/extras.js"></script>
850
851
852=== modified file 'lib/lp/registry/javascript/sharing/tests/test_granteetable.html'
853--- lib/lp/registry/javascript/sharing/tests/test_granteetable.html 2012-07-20 03:15:04 +0000
854+++ lib/lp/registry/javascript/sharing/tests/test_granteetable.html 2012-08-29 20:50:27 +0000
855@@ -58,7 +58,7 @@
856 <script type="text/javascript"
857 src="../../../../../../build/js/lp/app/effects/effects.js"></script>
858 <script type="text/javascript"
859- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
860+ src="../../../../../../build/js/lp/app/ui/ui.js"></script>
861 <script type="text/javascript"
862 src="../../../../../../build/js/lp/app/extras/extras.js"></script>
863 <script type="text/javascript"
864
865=== modified file 'lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html'
866--- lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html 2012-08-16 00:19:42 +0000
867+++ lib/lp/registry/javascript/sharing/tests/test_pillarsharingview.html 2012-08-29 20:50:27 +0000
868@@ -62,7 +62,7 @@
869 <script type="text/javascript"
870 src="../../../../../../build/js/lp/app/effects/effects.js"></script>
871 <script type="text/javascript"
872- src="../../../../../../build/js/lp/app/lazr/lazr.js"></script>
873+ src="../../../../../../build/js/lp/app/ui/ui.js"></script>
874 <script type="text/javascript"
875 src="../../../../../../build/js/lp/app/extras/extras.js"></script>
876 <script type="text/javascript"
877
878=== modified file 'lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.html'
879--- lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.html 2012-07-04 15:06:26 +0000
880+++ lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.html 2012-08-29 20:50:27 +0000
881@@ -30,7 +30,7 @@
882
883 <!-- Dependencies -->
884 <script type="text/javascript" src="../../../../../build/js/lp/app/client.js"></script>
885- <script type="text/javascript" src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
886+ <script type="text/javascript" src="../../../../../build/js/lp/app/ui/ui.js"></script>
887 <script type="text/javascript" src="../../../../../build/js/lp/app/extras/extras.js"></script>
888 <script type="text/javascript" src="../../../../../build/js/lp/app/anim/anim.js"></script>
889 <script type="text/javascript" src="../../../../../build/js/lp/app/effects/effects.js"></script>
890
891=== modified file 'lib/lp/translations/javascript/tests/test_importqueue.html'
892--- lib/lp/translations/javascript/tests/test_importqueue.html 2012-04-28 02:51:07 +0000
893+++ lib/lp/translations/javascript/tests/test_importqueue.html 2012-08-29 20:50:27 +0000
894@@ -26,7 +26,7 @@
895
896 <!-- Dependencies -->
897 <script type="text/javascript"
898- src="../../../../../build/js/lp/app/lazr/lazr.js"></script>
899+ src="../../../../../build/js/lp/app/ui/ui.js"></script>
900 <script type="text/javascript"
901 src="../../../../../build/js/lp/app/overlay/overlay.js"></script>
902 <script type="text/javascript"