Merge lp:~jcsackett/launchpad/get-rid-of-launchpadlib_for_anonymous-683748 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12134 | ||||
Proposed branch: | lp:~jcsackett/launchpad/get-rid-of-launchpadlib_for_anonymous-683748 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
109 lines (+10/-25) 4 files modified
lib/lp/blueprints/tests/test_webservice.py (+1/-2) lib/lp/registry/browser/tests/test_person_webservice.py (+2/-3) lib/lp/testing/__init__.py (+0/-1) lib/lp/testing/_webservice.py (+7/-19) |
||||
To merge this branch: | bzr merge lp:~jcsackett/launchpad/get-rid-of-launchpadlib_for_anonymous-683748 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+44115@code.launchpad.net |
Commit message
[r=sinzui]
Description of the change
Summary
=======
A few weeks ago a method was created to allow use of anonymous launchpadlib connections in tests. This method, launchpadlib_
Implementation
==============
* lib/lp/
Tests
=====
bin/test -t IHasSpecificati
bin/test -t PersonEmailSecurity
Lint
====
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
135: 'anonymous_
135: 'with_anonymous
154: 'launchpadlib_for' imported but unused
154: 'launchpadlib_
135: 'person_logged_in' imported but unused
154: 'oauth_
135: 'login_celebrity' imported but unused
135: 'with_celebrity
153: 'test_tales' imported but unused
135: 'celebrity_
135: 'run_with_login' imported but unused
135: 'is_logged_in' imported but unused
135: 'with_person_
135: 'login_team' imported but unused
135: 'login_person' imported but unused
135: 'login_as' imported but unused
502: E231 missing whitespace after ':'
707: E203 whitespace before ','
707: E231 missing whitespace after ','
920: E302 expected 2 blank lines, found 1
996: E302 expected 2 blank lines, found 1
./lib/lp/
155: Line exceeds 78 characters.
I will clean up the lint errors; I didn't want to pollute the diff with lint removals unrelated to the change. The various imports will remain as they exist to enable "from lp.testing import login_as" &c.
This looks good to land