Merge lp:~jcsackett/launchpad/darker-grays into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15391 |
Proposed branch: | lp:~jcsackett/launchpad/darker-grays |
Merge into: | lp:launchpad |
Prerequisite: | lp:~jcsackett/launchpad/better-status-colors |
Diff against target: |
43 lines (+4/-4) 2 files modified
lib/canonical/launchpad/icing/css/colours.css (+3/-3) lib/canonical/launchpad/icing/css/forms.css (+1/-1) |
To merge this branch: | bzr merge lp:~jcsackett/launchpad/darker-grays |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+109042@code.launchpad.net |
Commit message
Darkens some grays to be standards compliant.
Description of the change
Summary
=======
In fixing the colors in choiceedit for bug status, we discovered we had
several grays that were outside of the expected contrast requirements to be
standards compliant. This branch darkens those color to the maximum allowed
brightness of gray on white to be standards compliant.
Preimp
======
Spoke with Curtis Hovey.
Implementation
==============
Anything above #666 was changed to #666, per standards. I can go through the
process of creating screenshots, but these were all gray on white issues, and
almost all were status colors (e.g. MP status, bug status).
Tests
=====
None.
QA
==
None.
LoC
===
This is LoC neutral.
Lint
====
Our css linter and our css formats don't appear to agree; almost every line
has a problem. As this branch just changes one value for another, no *new*
lint errors have been introduced.
We should probably fix our CSS or fix our linter.
Thank you.