Merge lp:~jcsackett/launchpad/darker-grays into lp:launchpad

Proposed by j.c.sackett
Status: Merged
Approved by: Curtis Hovey
Approved revision: no longer in the source branch.
Merged at revision: 15391
Proposed branch: lp:~jcsackett/launchpad/darker-grays
Merge into: lp:launchpad
Prerequisite: lp:~jcsackett/launchpad/better-status-colors
Diff against target: 43 lines (+4/-4)
2 files modified
lib/canonical/launchpad/icing/css/colours.css (+3/-3)
lib/canonical/launchpad/icing/css/forms.css (+1/-1)
To merge this branch: bzr merge lp:~jcsackett/launchpad/darker-grays
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+109042@code.launchpad.net

Commit message

Darkens some grays to be standards compliant.

Description of the change

Summary
=======
In fixing the colors in choiceedit for bug status, we discovered we had
several grays that were outside of the expected contrast requirements to be
standards compliant. This branch darkens those color to the maximum allowed
brightness of gray on white to be standards compliant.

Preimp
======
Spoke with Curtis Hovey.

Implementation
==============
Anything above #666 was changed to #666, per standards. I can go through the
process of creating screenshots, but these were all gray on white issues, and
almost all were status colors (e.g. MP status, bug status).

Tests
=====
None.

QA
==
None.

LoC
===
This is LoC neutral.

Lint
====
Our css linter and our css formats don't appear to agree; almost every line
has a problem. As this branch just changes one value for another, no *new*
lint errors have been introduced.

We should probably fix our CSS or fix our linter.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/css/colours.css'
2--- lib/canonical/launchpad/icing/css/colours.css 2012-06-06 21:38:11 +0000
3+++ lib/canonical/launchpad/icing/css/colours.css 2012-06-11 14:47:06 +0000
4@@ -230,7 +230,7 @@
5 color: red;
6 }
7 .voteABSTAIN {
8- color: #bebebe;
9+ color: #666;
10 }
11 .votePENDING {
12 color: #f60;
13@@ -253,7 +253,7 @@
14 color: black;
15 }
16 .mergestatusSUPERSEDED, .mergestatusSUPERSEDED a {
17- color: #bebebe;
18+ color: #666;
19 }
20 .codeimportNEW {
21 color: #930;
22@@ -314,7 +314,7 @@
23 color: red;
24 }
25 .distromirrorstatusUNKNOWN {
26- color: #bebebe;
27+ color: #666;
28 }
29 .buildstatusNEEDSBUILD {
30 color: gray;
31
32=== modified file 'lib/canonical/launchpad/icing/css/forms.css'
33--- lib/canonical/launchpad/icing/css/forms.css 2012-03-20 03:01:07 +0000
34+++ lib/canonical/launchpad/icing/css/forms.css 2012-06-11 14:47:06 +0000
35@@ -71,7 +71,7 @@
36 .formHelp {
37 max-width: 45em;
38 margin: 0.2em 0 0.5em 0.2em;
39- color: #777;
40+ color: #666;
41 }
42 .listbox {
43 /* a scrolling list of checkboxes or radio buttons */