Merge lp:~jcsackett/launchpad/button-configs-break-pickers into lp:launchpad
Status: | Superseded | ||||||||
---|---|---|---|---|---|---|---|---|---|
Proposed branch: | lp:~jcsackett/launchpad/button-configs-break-pickers | ||||||||
Merge into: | lp:launchpad | ||||||||
Diff against target: |
291 lines (+63/-17) 9 files modified
lib/lp/app/browser/lazrjs.py (+5/-1) lib/lp/app/javascript/lazr/picker/person_picker.js (+12/-4) lib/lp/app/javascript/picker_patcher.js (+1/-5) lib/lp/app/javascript/tests/test_picker.js (+22/-4) lib/lp/app/widgets/popup.py (+7/-0) lib/lp/app/widgets/templates/form-picker-macros.pt (+4/-0) lib/lp/bugs/javascript/bugtask_index.js (+1/-0) lib/lp/code/browser/sourcepackagerecipe.py (+2/-1) lib/lp/registry/browser/team.py (+9/-2) |
||||||||
To merge this branch: | bzr merge lp:~jcsackett/launchpad/button-configs-break-pickers | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Launchpad code reviewers | Pending | ||
Review via email: mp+66946@code.launchpad.net |
This proposal has been superseded by a proposal from 2011-07-06.
Description of the change
Summary
=======
An earlier branch that set up configuration options for views regarding whether or not to show the extra buttons actually broke pickers by passing in "True" where javascript expects "true". This branch fixes that.
This sort of issue should go away once we address bug 799847, in particular the part about using the JSONCache.
Pre-implementation notes
=======
None.
Implementation details
=======
popup.py sets two variables regarding the assign me button and the remove assignee button, but sets them using python booleans. They've been updated to strings, which are interpreted in the form-macros into the appropriate javascript booleans (e.g. 'false' instead of False).
Callsites have been updated to pass in the correct assignments for these variables.
Tests
=====
bin/test -vvc --layer=YUI
QA
==
Check that clicking the Choose fields (e.g. on launchpad.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
./lib/lp/
552: local variable 'mailing_list' is assigned to but never used
Not sure what to do regaring the lint above; it seems like the sort of code that may accomplish something via side effect, and I can't find good tests to double check. I'll try to suss it out prior to landing it.