Merge lp:~jcsackett/launchpad/bug-tracker-inactive-projects into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merge reported by: | j.c.sackett | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~jcsackett/launchpad/bug-tracker-inactive-projects | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
77 lines (+24/-7) 2 files modified
lib/lp/bugs/browser/bugtracker.py (+2/-2) lib/lp/bugs/browser/tests/test_bugtracker_views.py (+22/-5) |
||||
To merge this branch: | bzr merge lp:~jcsackett/launchpad/bug-tracker-inactive-projects | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+124526@code.launchpad.net |
Description of the change
Summary
=======
This branch addresses a failure in the bugtracker index pages to not show
inactive projects, because we were doing nothing to filter them out.
Preimp
======
Spoke with Curtis Hovey.
Implementation
==============
The related_projects method used by the portlet has been updated to filter out
products that inactive.
Tests
=====
bin/test -vvct test_bugtracker
QA
==
Ensure that inactive projects are not in the bugtracker related project
portlet listing.
LoC
===
This branch has a followup branch that removes some of a doctest and adds it
to the created testcase here, netting slightly more LoC removed than this
branch adds. (See the branch dependent on this one).
Lint
====
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
./lib/lp/
53: local variable 'active_tracker2' is assigned to but never used
52: local variable 'active_tracker1' is assigned to but never used
I'm not addressing these as the function call is still necessary, and the
assignment helps the code be self documenting.
Thank you.