Merge lp:~jcsackett/launchpad/better-status-colors into lp:launchpad

[j.c.sackett]

Updates colors and choice-link style to make division between choice title and chioce description clearer in cases like INVALID bug status.

Summary
=======
On the new bugstatus picker, the INVALID and WONTFIX statuses are not clearly
separated from the description text, as they have the same color.

This color--gray--is a pretty good choice for the statuses, but the issue of
separation is important. This branch attempts to resolve the problem with a
lighter gray and some font-weight changes.

Implementation
==============
The font-weight of choiceedit choice-links is changed to bold; as these
*titles*, the use of bold text is not inconsistent.

The color of the INVALID and WONTFIX statuses is changed to light gray; this
is still readable, while maintaining the semantics of gray text and being
separate from the default gray we use in text.

The changes as seen in the bug status choiceedit can be seen here: http://people.canonical.com/~jc/images/bugstatus-color-issue.png

Tests
=====
None.

QA
==
Verify the presentation is right on qastaging.

LoC
===
This is part of the disclosure work.

Lint
====
Our css files don't appear to conform to the rules in our css linter; almost
every line came up as an error, and so the linting is not included. The
changed lines are consistent with the formats in the file.

[Curtis Hovey (sinzui)]

+1 for the bold

I think some of our shades of grey violate WCAG. We need more contrast. #666 is the lightest text can be. I bet we have shades that are higher.
/me looks

PSU has a cheatsheet for us! http://accessibility.psu.edu/contrasthtml

I see in colour.css that we use #999, #bebebe, and gray. We use these for status colours. I see in form.css that .formHelp used for descriptions is #777. I think the last must be changed to #666, and we may want the others to be #555

Can you try darker colours?

review: Needs Information (ui)

[j.c.sackett (jcsackett)]

Sure, I'll play with colors a bit. Sorry I missed you on IRC.

[j.c.sackett (jcsackett)]

Okay, darker colors are up, look good.

http://people.canonical.com/~jc/images/bugstatus-color-issue.png

[Curtis Hovey (sinzui)]

This is a very nice improvement. Thank you.

review: Approve (code)

=== modified file 'lib/canonical/launchpad/icing/css/colours.css'
--- lib/canonical/launchpad/icing/css/colours.css	2012-03-07 20:57:20 +0000
+++ lib/canonical/launchpad/icing/css/colours.css	2012-06-06 22:51:27 +0000
@@ -107,7 +107,7 @@
     }
 .statusINVALID, .statusINVALID a,
 .statusWONTFIX, .statusWONTFIX a {
-    color: gray;
+    color: #555;
     }
 .importanceCRITICAL, .importanceCRITICAL a {
     color: red;

=== modified file 'lib/lp/app/javascript/choiceedit/assets/choiceedit-core.css'
--- lib/lp/app/javascript/choiceedit/assets/choiceedit-core.css	2012-05-16 02:09:30 +0000
+++ lib/lp/app/javascript/choiceedit/assets/choiceedit-core.css	2012-06-06 22:51:27 +0000
@@ -47,11 +47,12 @@
 }
 .yui3-ichoicelist-content .choice-link {
   padding: 0;
+  font-weight: bold;
 }
 .yui3-ichoicelist-content .choice-description {
   font-weight: normal;
   padding: 0;
-  color: #777;
+  color: #666;
 }
 .yui3-ichoicelist-content .choice-link:hover {
   text-decoration: underline;