Merge lp:~jcsackett/launchpad/autofocus into lp:launchpad

[j.c.sackett]

[r=leonardr][ui=none][bug=135009,135012,135015,135018] Adds autofocus to several fields needing it throughout Launchpad

Summary
=======

A number of search fields should auto focus on page load, and do not. This adds auto focus to those forms/fields.

Preimplemenation Talk
=====================

Spoke with Curtis Hovey about how to set auto focus.

Implementation
==============

lib/lp/app/templates/root-index.pt
lib/lp/registry/templates/projects-index.pt
lib/lp/code/templates/bazaar-index.pt
lib/lp/blueprints/templates/specifications-index.pt
---------------------------------------------------

In each file, added setFocusByName to the template for the form as it has been used elsewhere.

Demo & QA
=========

Open http://blueprints.launchpad.dev/; the search field should get focus
Open http://code.launchpad.dev/; the search field should get focus
Open http://launchpad.dev/projects; the search field should get focus
Open http://launchpad.dev/; the search field should get focus

[Leonard Richardson (leonardr)]

Approved, assuming that the inputs mentioned in setFocusByName will always be present. (As far as I can tell by looking at the code, this is the case.)

review: Approve

[j.c.sackett (jcsackett)]

> Approved, assuming that the inputs mentioned in setFocusByName will always be present.

That is the case; in each case the javascript is loaded after the form loads, and the form is not dynamic in nature.

=== modified file 'lib/lp/app/templates/root-index.pt'
--- lib/lp/app/templates/root-index.pt	2010-12-16 16:21:07 +0000
+++ lib/lp/app/templates/root-index.pt	2010-12-21 15:14:53 +0000
@@ -164,6 +164,9 @@
               <input id="text" type="text" name="field.text" size="25%" />
               <input id="search" type="submit" value="Search Launchpad" />
             </form>
+            <script type="text/javascript"><!--
+              setFocusByName('field.text');
+            // --></script>
             <div id="homepage-stats" tal:content="cache:public, 1 hour">
               <strong class="registry-stat"
                 tal:content="view/project_count/fmt:intcomma">123</strong>&nbsp;projects,

=== modified file 'lib/lp/blueprints/templates/specifications-index.pt'
--- lib/lp/blueprints/templates/specifications-index.pt	2009-09-21 17:21:57 +0000
+++ lib/lp/blueprints/templates/specifications-index.pt	2010-12-21 15:14:53 +0000
@@ -71,6 +71,10 @@
           </tbody>
         </table>
       </form>
+      <script type="text/javascript"><!--
+         setFocusByName('field.search_text');
+       // --></script>
+
       <tal:searchresults condition="view/searchrequested"
                          define="specs view/specs" >
         <p tal:condition="specs">

=== modified file 'lib/lp/code/templates/bazaar-index.pt'
--- lib/lp/code/templates/bazaar-index.pt	2010-12-13 10:16:37 +0000
+++ lib/lp/code/templates/bazaar-index.pt	2010-12-21 15:14:53 +0000
@@ -38,6 +38,10 @@
         <input id="text" type="text" name="text" size="50" />
         <input type="submit" value="Find a Project" />
       </form>
+      <script type="text/javascript"><!--
+         setFocusByName('text');
+       // --></script>
+
       <p id="application-summary">
         Launchpad can host your project&#8217;s source code
         using the <a href="http://bazaar.canonical.com/">Bazaar</a>

=== modified file 'lib/lp/registry/templates/projects-index.pt'
--- lib/lp/registry/templates/projects-index.pt	2010-01-12 14:36:46 +0000
+++ lib/lp/registry/templates/projects-index.pt	2010-12-21 15:14:53 +0000
@@ -33,6 +33,9 @@
           tal:condition="not: view/search_requested"
           type="submit" value="Search project groups" />
       </form>
+      <script type="text/javascript"><!--
+         setFocusByName('text');
+       // --></script>
 
       <div tal:condition="view/search_requested">
           <tal:searching condition="view/search_results">