Reviewers: mp+161894_code.launchpad.net,

Message:
Please take a look.

Description:
Resolves views rendering in partly scrolled state

This branch resolves two bugs wherein a view rendered scrolled partway
down.
This appears to be an issue with browser behavior rather than JS, as
investigation showed no problem when debuggers were used to check state
as the
views render.

To get around that, this branch simply grabs the top-most visible
element of
the two views and ensures they're scrolled into view.

https://code.launchpad.net/~jcsackett/juju-gui/scroll-to-top-on-change/+merge/161894

(do not edit description out of merge proposal)


Please review this at https://codereview.appspot.com/9088043/

Affected files:
   A [revision details]
   M app/subapps/browser/views/charm.js
   M app/subapps/browser/views/editorial.js
   M app/subapps/browser/views/search.js


Index: [revision details]
=== added file '[revision details]'
--- [revision details]	2012-01-01 00:00:00 +0000
+++ [revision details]	2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: app/subapps/browser/views/charm.js
=== modified file 'app/subapps/browser/views/charm.js'
--- app/subapps/browser/views/charm.js	2013-05-01 07:55:53 +0000
+++ app/subapps/browser/views/charm.js	2013-05-01 17:20:47 +0000
@@ -444,7 +444,6 @@

        var tplData = charm.getAttrs(),
            container = this.get('container');
-
        tplData.isFullscreen = isFullscreen;
        tplData.prettyCommits = this._formatCommitsForHtml(
            tplData.recent_commits);
@@ -463,7 +462,8 @@

        // Set the content then update the container so that it reload
        // events.
-      this.get('renderTo').setHTML(tplNode);
+      var viewData = Y.one('.bws-view-data');
+      viewData.setHTML(tplNode);

        this.tabview = new widgets.browser.TabView({
          srcNode: tplNode.one('.tabs')
@@ -481,6 +481,9 @@
        } else {
          this._noReadme(tplNode.one('#bws-readme'));
        }
+      // Scroll the nav bar into view, so we load the charm view at the  
top of
+      // the content.
+      viewData.one('.nav').scrollIntoView();
      },

      /**


Index: app/subapps/browser/views/editorial.js
=== modified file 'app/subapps/browser/views/editorial.js'
--- app/subapps/browser/views/editorial.js	2013-04-30 16:06:00 +0000
+++ app/subapps/browser/views/editorial.js	2013-05-01 17:20:47 +0000
@@ -96,7 +96,7 @@
       * @param {Object} request the original io_request object for  
debugging.
       */
      apiFailure: function(data, request) {
-      this._apiFailure(data, request, 'Failed to load sidebar content.');
+      this._apiFailure(data, request, 'Failed to load editorial content.');
      },

      /**


Index: app/subapps/browser/views/search.js
=== modified file 'app/subapps/browser/views/search.js'
--- app/subapps/browser/views/search.js	2013-04-30 15:25:49 +0000
+++ app/subapps/browser/views/search.js	2013-05-01 17:20:47 +0000
@@ -135,6 +135,9 @@
        this._renderFilterWidget(filter_container);
        this.get('container').setHTML(tplNode);
        target.setHTML(this.get('container'));
+      // Scroll the heading into view to ensure view renders at the top of  
the
+      // content.
+      target.one('.search-title').scrollIntoView();
      },

      /**