lp:~jcsackett/charmworld/fix-enqueue-sort-failure

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:charmworld at revision 480

Juju Gui Bot: Approve (continuous-integration) on 2014-01-22

j.c.sackett (community): Approve on 2014-01-22

Brad Crittenden (community): Approve (code) on 2014-01-22

Diff: 34 lines (+2/-4)

2 files modified

charmworld/jobs/lp.py (+1/-3)
charmworld/jobs/tests/test_lp.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

481. By j.c.sackett on 2014-01-22

Shut up, lint.

480. By j.c.sackett on 2014-01-22

db_charms doesn't need to sort, and mongo doesn't like no index sorts.

479. By Benji York on 2014-01-21

Add a very useful hint about relation ordering.

Approved by Juju Gui Bot.

478. By j.c.sackett on 2014-01-17

Improves the trigger_tests function with logging, and corrects an error in url construction.

Approved by Juju Gui Bot, Curtis Hovey.

477. By Brad Crittenden on 2014-01-16

Clear queues at ingest startup.

Bundles seem to get stuck when the job entries are locked and the ingest
process dies, such as happens when charm attributes are set or the charm gets
updated.

To avoid having the queues littered with items that never go away, which is
disconcerting to the casual viewer of /heartbeat, this branch introduces a new
--clear option to the queueing process which is used by the worker on the
first invocation

This branch also addresses a few other issues by being more defensive in the
face of charms and bundles that are non-standard in a number of ways.

* Handle the lack of 'bundles.yaml' gracefully.

* Handle SVG files with float placement values.

* Handle charms with no files. The only instance I've seen of this occurring
  is with a charm that is private in Launchpad, so I cannot assess how it
  happens.

https://codereview.appspot.com/51010046/

R=rharding.

Approved by Juju Gui Bot.

476. By Brad Crittenden on 2014-01-14

Properly proof bundles with inheritance.

- Use the existing get_flattened_deployment to realize the inheritance.
- Update to new version of charm-tools.
- Specify version for charmworldlib rather than grabbing the latest from pypi.
- Add work-around to forking charm-tools to allow proofing on localhost during
  ingest.

QA:

In one terminal:
% make run

In another:
% bin/ingest-queued --prefix=~bac

Ensure that ~bac/charms/bundle/complicated/bundle ingests A-OK.

https://codereview.appspot.com/51650043/

R=rharding. Fixes: https://bugs.launchpad.net/bugs/1263112.

Approved by Juju Gui Bot.

475. By j.c.sackett on 2014-01-14

Automatically trigger builds for new charms and new revisions of existing charms.

Approved by Juju Gui Bot, Curtis Hovey.

474. By Brad Crittenden on 2014-01-08

Add two more questions to QA assessment.

https://codereview.appspot.com/49030044/

R=bac.

Approved by Juju Gui Bot.

473. By Brad Crittenden on 2014-01-07

Fix a bug that killed the worker.

Fixed 'wait_seconds' and added missing tests.
Added stanzas for logging that are required until the production overrides in
the charm are brought in.

QA: run 'bin/ingest-queued --limit=10 --debug --run-forever' and see that it
waits before proceeding.

https://codereview.appspot.com/48540043/

R=rharding.

Approved by Juju Gui Bot.

472. By Benji York on 2014-01-06

Add docs for setting up ES and Nagios

Also fixed a branch URL in the docs that was no longer valid.

Approved by Juju Gui Bot.