lp:~jcsackett/charmworld/better-review-charting

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:charmworld at revision 486

Juju Gui Bot: Approve (continuous-integration) on 2014-02-19

Brad Crittenden (community): Approve (code) on 2014-02-19

Diff: 124 lines (+12/-33)

4 files modified

charmworld/static/sparklines.js (+1/-1)
charmworld/templates/review.pt (+0/-8)
charmworld/views/tests/test_tools.py (+3/-9)
charmworld/views/tools.py (+8/-15)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

485. By j.c.sackett on 2014-02-18

Merged trunk.

484. By j.c.sackett on 2014-02-18

Updates and test fixes.

483. By j.c.sackett on 2014-02-14

Merged trunk.

482. By j.c.sackett on 2014-02-14

Remove everything but average time from charting.

481. By j.c.sackett on 2014-02-14

Merged lp:~jcsackett/charmworld/sparkline-tweak, as long as we're modifying the charting.

480. By j.c.sackett on 2014-01-22

Fixes an enqueue error for ingest that occurs because of a non-indexed sort.

Approved by Juju Gui Bot, j.c.sackett, Brad Crittenden.

479. By Benji York on 2014-01-21

Add a very useful hint about relation ordering.

Approved by Juju Gui Bot.

478. By j.c.sackett on 2014-01-17

Improves the trigger_tests function with logging, and corrects an error in url construction.

Approved by Juju Gui Bot, Curtis Hovey.

477. By Brad Crittenden on 2014-01-16

Clear queues at ingest startup.

Bundles seem to get stuck when the job entries are locked and the ingest
process dies, such as happens when charm attributes are set or the charm gets
updated.

To avoid having the queues littered with items that never go away, which is
disconcerting to the casual viewer of /heartbeat, this branch introduces a new
--clear option to the queueing process which is used by the worker on the
first invocation

This branch also addresses a few other issues by being more defensive in the
face of charms and bundles that are non-standard in a number of ways.

* Handle the lack of 'bundles.yaml' gracefully.

* Handle SVG files with float placement values.

* Handle charms with no files. The only instance I've seen of this occurring
  is with a charm that is private in Launchpad, so I cannot assess how it
  happens.

https://codereview.appspot.com/51010046/

R=rharding.

Approved by Juju Gui Bot.

476. By Brad Crittenden on 2014-01-14

Properly proof bundles with inheritance.

- Use the existing get_flattened_deployment to realize the inheritance.
- Update to new version of charm-tools.
- Specify version for charmworldlib rather than grabbing the latest from pypi.
- Add work-around to forking charm-tools to allow proofing on localhost during
  ingest.

QA:

In one terminal:
% make run

In another:
% bin/ingest-queued --prefix=~bac

Ensure that ~bac/charms/bundle/complicated/bundle ingests A-OK.

https://codereview.appspot.com/51650043/

R=rharding. Fixes: https://bugs.launchpad.net/bugs/1263112.

Approved by Juju Gui Bot.