lp:~jcsackett/charmworld/better-latency-round-2
- Get this branch:
- bzr branch lp:~jcsackett/charmworld/better-latency-round-2
Branch merges
- Juju Gui Bot: Approve (continuous-integration)
- Aaron Bentley (community): Approve
-
Diff: 374 lines (+182/-76)3 files modified.bzrignore (+1/-0)
charmworld/jobs/review.py (+74/-30)
charmworld/jobs/tests/test_review.py (+107/-46)
Branch information
Recent revisions
- 461. By j.c.sackett
-
Bzr should ignore our conventional lp credentials file, so we don't accidentally commit it.
- 458. By j.c.sackett
-
Update store and qa errors in review queue to only show latest version of charms with errors.
Approved by Juju Gui Bot, Curtis Hovey.
- 456. By Brad Crittenden
-
Make tilde in search field not crash.
Also, convert ~foo into owner: foo, assuming that's what is wanted.
https:/
/codereview. appspot. com/23760043/ R=gary. Fixes: https:/
/bugs.launchpad .net/bugs/ 1248990. Approved by Juju Gui Bot.
- 455. By Abel Deuring
-
Add two more checks to the heartbeat page: Status of the ElasticSearch server ans the current bzr revision number.
Approved by Juju Gui Bot, Curtis Hovey.
- 454. By Benji York
-
Add an API for bundle metrics
https:/
/codereview. appspot. com/23740043/ R=bac.
Approved by Juju Gui Bot.
- 453. By Richard Harding
-
Allow implicit juju-* relations to be valid.
- https:/
/juju.ubuntu. com/docs/ authors- implicit- relations. html
- juju-* is a namespace for implicit juju relations all charms support. This
adds a check for relations that start with juju- and auto approve them in
proof.
- Charms are not allowed to create any relation of their own that start with
juju-, so it's safe to assume anything that starts with this is a safe
implicit relation.https:/
/codereview. appspot. com/23660043/ R=benji.
Approved by Juju Gui Bot.
- 452. By Richard Harding
-
Update proof to handle 0 rev charms.
- When parsing the store url for a rev the regex would return the int 0
- Proof checks to determine if a revision was defined would use if revision
and fail (bool(0) == False)
- Updates the if checks to use if revision is not None, if revision is None
directly.https:/
/codereview. appspot. com/23600043/ R=bac.
Approved by Juju Gui Bot.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:charmworld