Merge lp:~jcsackett/charms/precise/charmworld/fix-lp-creds-ini-override into lp:~juju-jitsu/charms/precise/charmworld/trunk

Proposed by j.c.sackett
Status: Merged
Merged at revision: 85
Proposed branch: lp:~jcsackett/charms/precise/charmworld/fix-lp-creds-ini-override
Merge into: lp:~juju-jitsu/charms/precise/charmworld/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
production_overrides.ini (+1/-1)
To merge this branch: bzr merge lp:~jcsackett/charms/precise/charmworld/fix-lp-creds-ini-override
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email:

Commit message

Fix lp_credentials data in production_overrides.ini

Description of the change

The variable for lp_credentials in production_overrides shouldn't be quoted; python already quotes string values as it gets them from the ini. Quoted, the path ends up as "'/home/webops_deploy/charmworld/charmbot_credentials.txt'", which the review job can't then interpret as a path.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'production_overrides.ini'
2--- production_overrides.ini 2013-11-07 16:01:06 +0000
3+++ production_overrides.ini 2013-11-13 21:47:04 +0000
4@@ -5,7 +5,7 @@
5 =
6 mongo.port =
7 mongo.url =
8-lp_credentials_file = "/home/webops_deploy/charmworld/charmbot_credentials.txt"
9+lp_credentials_file = /home/webops_deploy/charmworld/charmbot_credentials.txt
10 proof.port = 6543
12 [server:main]


People subscribed via source and target branches

to all changes: