Merge lp:~jcsackett/charms/precise/charmworld/add-jenkins into lp:~juju-jitsu/charms/precise/charmworld/trunk

Proposed by j.c.sackett
Status: Merged
Approved by: j.c.sackett
Approved revision: 92
Merged at revision: 89
Proposed branch: lp:~jcsackett/charms/precise/charmworld/add-jenkins
Merge into: lp:~juju-jitsu/charms/precise/charmworld/trunk
Diff against target: 80 lines (+30/-2)
3 files modified
config.yaml (+15/-0)
production_overrides.ini (+3/-0)
scripts/write_config.py (+12/-2)
To merge this branch: bzr merge lp:~jcsackett/charms/precise/charmworld/add-jenkins
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+201582@code.launchpad.net

Commit message

Add necessary config options for triggering jenkins test builds of ingested charms.

Description of the change

This branch adds the jenkins ini file options for charmworld to the config, and updates the config generation to include them in building production.ini

This cannot be landed until https://code.launchpad.net/~jcsackett/charmworld/trigger-test-builds/+merge/201466 lands.

To post a comment you must log in.
91. By j.c.sackett

Fixed bad overrides.ini

92. By j.c.sackett

Remove remaining bad jenkins references.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-01-07 18:39:21 +0000
3+++ config.yaml 2014-01-14 16:32:34 +0000
4@@ -56,3 +56,18 @@
5 default: ''
6 description: |
7 The lp credentials to use with charmworld ingest, if available.
8+ charm_testing_url:
9+ type: string
10+ default: ''
11+ description: |
12+ The url of the testing service (e.g. jenkins) used for charm testing
13+ charm_testing_token:
14+ type: string
15+ default: ''
16+ description: |
17+ The token needed for triggering builds
18+ charm_testing_job:
19+ type: string
20+ default: ''
21+ description: |
22+ The name of the job running the test.
23
24=== modified file 'production_overrides.ini'
25--- production_overrides.ini 2014-01-07 18:39:21 +0000
26+++ production_overrides.ini 2014-01-14 16:32:34 +0000
27@@ -7,6 +7,9 @@
28 mongo.url =
29 lp_credentials_file = /home/webops_deploy/charmworld/charmbot_credentials.txt
30 proof.port = 6543
31+charm_testing_url =
32+charm_testing_token =
33+charm_testing_job =
34
35 [server:main]
36 port = 6543
37
38=== modified file 'scripts/write_config.py'
39--- scripts/write_config.py 2014-01-02 14:19:13 +0000
40+++ scripts/write_config.py 2014-01-14 16:32:34 +0000
41@@ -21,7 +21,8 @@
42
43 def write_new_config(mongo_url, es_url, error_handler, charm_import_limit,
44 worker_interval, default, override, target, es_replicas,
45- es_shards):
46+ es_shards, charm_testing_url, charm_testing_token,
47+ charm_testing_job):
48 new_config = read_config([default, override])
49 new_config.set('app:main', 'mongo.url', mongo_url)
50 new_config.set('app:main', 'es_urls', es_url)
51@@ -45,6 +46,9 @@
52 'app:main', 'worker_interval', worker_interval)
53 new_config.set('app:main', 'es_replicas', es_replicas)
54 new_config.set('app:main', 'es_shards', es_shards)
55+ new_config.set('app:main', 'charm_testing_url', charm_testing_url)
56+ new_config.set('app:main', 'charm_testing_token', charm_testing_token)
57+ new_config.set('app:main', 'charm_testing_job', charm_testing_job)
58 with open(target, 'w') as output:
59 new_config.write(output)
60
61@@ -132,12 +136,18 @@
62 worker_interval = juju_config['worker-interval']
63 es_shards = juju_config['es_shards']
64 es_replicas = juju_config['es_replicas']
65+ charm_testing_url = juju_config['charm_testing_url']
66+ charm_testing_token = juju_config['charm_testing_token']
67+ charm_testing_job = juju_config['charm_testing_job']
68
69 write_new_config(get_mongo_url(), get_elasticsearch_url(),
70 get_error_handler(), charm_import_limit,
71 worker_interval, default=sys.argv[1],
72 override=sys.argv[2], target=sys.argv[3],
73- es_replicas=es_replicas, es_shards=es_shards)
74+ es_replicas=es_replicas, es_shards=es_shards,
75+ charm_testing_url=charm_testing_url,
76+ charm_testing_token=charm_testing_token,
77+ charm_testing_job=charm_testing_job)
78
79
80 if __name__ == '__main__':

Subscribers

People subscribed via source and target branches

to all changes: