Messaging Menu

Merge lp:~jconti/indicator-messages/lp1113721 into lp:indicator-messages/13.04

  1. lp1113721
  2. Merge into trunk.13.04
Proposed by Jason Conti
Status: Merged
Approved by: Lars Karlitski
Approved revision: 337
Merged at revision: 337
Proposed branch: lp:~jconti/indicator-messages/lp1113721
Merge into: lp:indicator-messages/13.04
Diff against target: 19 lines (+2/-2)
1 file modified
libmessaging-menu/messaging-menu.c (+2/-2)
To merge this branch: bzr merge lp:~jconti/indicator-messages/lp1113721
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+148037@code.launchpad.net

Description of the change

A bit of refactoring in libmessaging-menu/messaging-menu.c has resulted in draws_attention always being set to TRUE. This branch fixes _set_draws_attention and _remove_attention so they set the appropriate value.

To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) wrote :

Oh wow, how did this happen!?

Thanks a lot Jason, the fix works.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libmessaging-menu/messaging-menu.c'
2--- libmessaging-menu/messaging-menu.c 2012-11-22 08:42:27 +0000
3+++ libmessaging-menu/messaging-menu.c 2013-02-12 19:49:24 +0000
4@@ -717,7 +717,7 @@
5 state = g_action_get_state (G_ACTION (action));
6 g_variant_get (state, "(ux&sb)", &count, &time, &string, NULL);
7
8- new_state = g_variant_new ("(uxsb)", count, time, string, TRUE);
9+ new_state = g_variant_new ("(uxsb)", count, time, string, draws_attention);
10 g_simple_action_set_state (action, new_state);
11
12 g_variant_unref (state);
13@@ -1191,5 +1191,5 @@
14 messaging_menu_app_remove_attention (MessagingMenuApp *app,
15 const gchar *source_id)
16 {
17- messaging_menu_app_set_draws_attention (app, source_id, TRUE);
18+ messaging_menu_app_set_draws_attention (app, source_id, FALSE);
19 }

Subscribers

People subscribed via source and target branches