gdebi

Merge lp:~jconti/gdebi/closeable-cache into lp:gdebi

  1. closeable-cache
  2. Merge into trunk
Proposed by Jason Conti
Status: Work in progress
Proposed branch: lp:~jconti/gdebi/closeable-cache
Merge into: lp:gdebi
Diff against target: 0 lines
To merge this branch: bzr merge lp:~jconti/gdebi/closeable-cache
Reviewer Review Type Date Requested Status
Luca Falavigna (community) Disapprove
Review via email: mp+182501@code.launchpad.net

Description of the change

Close the apt cache before we create another, so we do not leak file descriptors.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

While this merge proposal looks empty there is actually a change in the closeable-cache branch that does not exist in gdebi.

See line 66 and 67 at http://bazaar.launchpad.net/~jconti/gdebi/closeable-cache/revision/429.

Reply
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Already fixed in r438:
http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/438

review: Disapprove
Reply
Revision history for this message
Jason Conti (jconti) wrote :

Ah, sorry about that, I was looking at the wrong branch.

Reply
Revision history for this message
Jason Conti (jconti) wrote :

Sorry, no, it was the correct branch but it was reverted in: http://bazaar.launchpad.net/~gdebi-developers/gdebi/trunk/revision/440

Reply
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Indeed, I'll have a look shortly.

Reply

Unmerged revisions

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to status/vote changes: