Merge ~jchittum/ubuntu/+source/lxd-installer:devel-channel-version-selector into ubuntu/+source/lxd-installer:ubuntu/devel

[John Chittum]

fix: update channel selection to ubuntu-VERSION_ID

[Simon Déziel (sdeziel)]

LGTM and Tom Parrott also agreed. Thanks!

review: Approve

[Chad Smith (chad.smith)]

2 issues I think here.

1. Don't we expect noble or any non jammy/focal release to be `latest/stable` channel?

I think that warrants a default setting that clears channel_suffix to "stable"

2. No current channels exists with format `stable/ubuntu-XX.YY` We probably need those channels for lxd snap to show up before landing this right?

```
snap-id: J60k4JY0HppjwOjW8dZdYc8obXKxujRu
tracking: 5.16/stable
refresh-date: 2023-08-30
channels:
  latest/stable: 5.19-8635f82 2023-11-22 (26200) 159MB -
  latest/candidate: 5.19-b8ce621 2023-12-04 (26415) 158MB -
  latest/beta: ↑
  latest/edge: git-fdc3dc6 2023-12-05 (26461) 158MB -
  5.19/stable: 5.19-31ff7b6 2023-10-20 (26093) 159MB -
  5.19/candidate: ↑
  5.19/beta: ↑
  5.19/edge: ↑
  5.18/stable: 5.18-762f582 2023-09-26 (25748) 189MB -
  5.18/candidate: ↑
  5.18/beta: ↑
  5.18/edge: ↑
  5.17/stable: 5.17-e5ead86 2023-08-29 (25505) 184MB -
  5.17/candidate: ↑
  5.17/beta: ↑
  5.17/edge: ↑
  5.16/stable: 5.16-f2b0200 2023-07-26 (25353) 183MB -
  5.16/candidate: ↑
  5.16/beta: ↑
  5.16/edge: ↑
  5.15/stable: 5.15-3fe7435 2023-06-28 (25086) 181MB -
  5.15/candidate: ↑
  5.15/beta: ↑
  5.15/edge: ↑
  5.0/stable: 5.0.2-838e1b2 2023-01-25 (24322) 117MB -
  5.0/candidate: 5.0.2-838e1b2 2023-01-18 (24322) 117MB -
  5.0/beta: ↑
  5.0/edge: git-250277b 2023-12-05 (26449) 126MB -
  4.0/stable: 4.0.9-a29c6f1 2022-12-04 (24061) 96MB -
  4.0/candidate: 4.0.9-a29c6f1 2022-12-02 (24061) 96MB -
  4.0/beta: ↑
  4.0/edge: git-407205d 2022-11-22 (23988) 96MB -
  3.0/stable: 3.0.4 2019-10-10 (11348) 55MB -
  3.0/candidate: 3.0.4 2019-10-10 (11348) 55MB -
  3.0/beta: ↑
  3.0/edge: git-81b81b9 2019-10-10 (11362) 55MB -
installed: 5.16-f2b0200 (25353) 183MB -
```

[Chad Smith (chad.smith)]

Thanks John. Acknowledged here, and approved. I didn't grok the stable channels/branches aliases as I made those comments. I confirm this works as designed and pulls latest/stable/ubuntu-24.04 even on devel releases like noble,

review: Approve

[Chad Smith (chad.smith)]

And confired jammy/focal success installing from the following respective channels.
--channel=5.0/stable/ubuntu-22.04
--channel=5.0/stable/ubuntu-20.04

[Andreas Hasenack (ahasenack)]

This is missing a debian/changelog entry, which should also refer to LP: #2044185

review: Needs Fixing

[Andreas Hasenack (ahasenack)]

Thanks, +1

review: Approve

[Andreas Hasenack (ahasenack)]

Sponsored:

Uploading lxd-installer_3.dsc
Uploading lxd-installer_3.tar.xz
Uploading lxd-installer_3_source.buildinfo
Uploading lxd-installer_3_source.changes

diff --git a/debian/changelog b/debian/changelog
index 97e238f..6d504f0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+lxd-installer (3) noble; urgency=medium
+
+  * update channel selection to ubuntu-VERSION_ID (LP: #2044185)
+
+ -- jchittum <[e-mail]>  Wed, 13 Dec 2023 14:32:38 -0600
+
 lxd-installer (2) noble; urgency=medium
 
   * Pick the proper snap channel (LP: #2043843)
diff --git a/lxd-installer-service b/lxd-installer-service
index 7d814ca..536f316 100644
--- a/lxd-installer-service
+++ b/lxd-installer-service
@@ -1,19 +1,22 @@
 #!/bin/sh
 lxd_channel() {
-    channel="5.0/stable"
+    channel_version="latest"
 
+    # lxd follows a pattern of $VERSION/stable/ubuntu-$VERSION
+    # default in development is "latest"
+    # with major version assigned and opened prior to Ubuntu release
     # shellcheck disable=SC1091
     [ -r /etc/os-release ] && . /etc/os-release
+    channel_suffix="stable/ubuntu-${VERSION_ID}"
     case "${UBUNTU_CODENAME:-""}" in
-      "noble")
-        channel="6.0/stable";;
+      "jammy")
+        channel_version="5.0";;
       "focal")
-        channel="4.0/stable";;
+        channel_version="4.0";;
       *)
         ;;
     esac
-
-    echo "${channel}"
+    echo "${channel_version}/${channel_suffix}"
 }
 
 snap install lxd --channel="$(lxd_channel)" 1>&2