Merge ~jchittum/ubuntu/+source/freeradius:plucky-remove-wtmpdb into ubuntu/+source/freeradius:ubuntu/devel

[John Chittum]

tested builds and installs locally and in PPA

https://launchpad.net/~jchittum/+archive/ubuntu/freeradius-2096611

radlast was not installed

$ apt-cache policy freeradius
freeradius:
  Installed: (none)
  Candidate: 3.2.7+dfsg-1ubuntu1~ppa2
  Version table:
     3.2.7+dfsg-1ubuntu1~ppa2 500
        500 https://ppa.launchpadcontent.net/jchittum/freeradius-2096611/ubuntu plucky/main amd64 Packages
     3.2.7+dfsg-1 500
        500 http://archive.ubuntu.com/ubuntu plucky/main amd64 Packages
$ sudo apt install freeradius
<snip>
$ radlast
Could not find command-not-found database. Run 'sudo apt update' to populate it.
radlast: command not found
$ which radlast

[Andreas Hasenack (ahasenack)]

What do you think about a d/NEWS.Debian entry? There is one already talking about the radlast problem, and acknowledging that a broken radlast script is being shipped. We could add one where we state that ubuntu has stopped shipping that script.

5181d9f... by John Chittum on 2025-03-04

d/NEWS add entry for Ubuntu specific change

[Andreas Hasenack (ahasenack)]

Sorry, I missed your update here. Just new commits don't trigger an email notification: it has to be an actual MP comment to get a notification that something changed in the PR :/

[Andreas Hasenack (ahasenack)]

This looks good, thanks. But I think we need to ask the release team about it, even though we are dropping a command that doesn't work.

I'll give a +1 here, and sponsor once the release team ACKed the change. Would you mind getting them involved? Change the bug description slightly, putting the important TL;DR at the top. Perhaps this;

"""
This means the current version of freeradius in Plucky ships a command that is unusable, and removed in future versions. add a delta to stop shipping radlast, and ensure this delta is removed in subsequent syncs from Debian.
"""

And then show the relevant parts of the diff from this MP right below that. And add a release notes task to the bug, so that this change will be added to the release notes of 25.04. Finally, link to the PPA with the green builds and DEP8 tests, and then subscribe ubuntu-release.

review: Approve

[Andreas Hasenack (ahasenack)]

I just triggered the DEP8 tests in your PPA.

[git-ubuntu bot (git-ubuntu-bot)]

Approvers: ahasenack, jchittum
Uploaders: ahasenack
MP auto-approved

review: Approve

Unmerged commits

5181d9f... by John Chittum on 2025-03-04

d/NEWS add entry for Ubuntu specific change

5b34c3c... by John Chittum on 2025-03-03

d/changelog update

9428c61... by John Chittum on 2025-03-03

d/rules and install: no longer compile radlast

radlast became an optional compile flag upstream.[0] Debian decided
to continue compiling with `--with-radlast` in 3.2.7. This leads to
including a tool that is unrunnable on Ubuntu (and Debian). Upstream has
completely removed radlast from future releases.[1] This puts us closer
to upstream, removing optional builds and installs

[0] https://github.com/FreeRADIUS/freeradius-server/commit/fece06e2f4984a1f4c227ba9ef3edf4a8ad5e2ee
[1] https://github.com/FreeRADIUS/freeradius-server/commit/b0f4123c84a0aeaa6fc393fd5e6fdaa0e0a86eaf

diff --git a/debian/NEWS.Debian b/debian/NEWS.Debian
index ef9b192..0c6d412 100644
--- a/debian/NEWS.Debian
+++ b/debian/NEWS.Debian
@@ -1,3 +1,18 @@
+freeradius (3.2.7+dfsg-1ubuntu1) plucky; urgency=medium
+
+  FreeRADIUS upstream has disabled the creation of radlast due to the
+  deprecation of the last command. last was removed from Debian and Ubuntu
+  due to not being year-2038 safe. Previously the FreeRADIUS Debian
+  package introduced a dependency on wtmpdb, however wtpmdb is a replacement
+  for system login tracking with PAM hooks and writing to an sqlite database.
+  wtmpdb did not provide a wtmp file compatible last command.
+
+  Debian has chosen to continue shipping unusable radlast command until
+  it is removed upstream. Ubuntu has made the choice to no longer compile
+  radlast and include it in the package. As of 20250304, upstream source
+  has already removed radlast and other older tools from FreeRADIUS.
+  However they have not released those changes yet.
+
 freeradius (3.2.7+dfsg-1) unstable; urgency=medium
 
   FreeRADIUS can write a log of logins to the radwtmp database meant to
diff --git a/debian/changelog b/debian/changelog
index c4d52e6..e42e2f0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+freeradius (3.2.7+dfsg-1ubuntu1) plucky; urgency=medium
+
+  * d/rules & d/freeradius-utils.install
+    remove `radlast` from builds. there is no `last` implementation available
+    in oracular+ and compilation has become optional. (LP: #2096611)
+
+ -- John Chittum <[e-mail]>  Fri, 28 Feb 2025 07:28:14 -0500
+
 freeradius (3.2.7+dfsg-1) unstable; urgency=medium
 
   * New upstream version 3.2.7+dfsg
diff --git a/debian/freeradius-utils.install b/debian/freeradius-utils.install
index 3653fd3..be43d11 100644
--- a/debian/freeradius-utils.install
+++ b/debian/freeradius-utils.install
@@ -1,7 +1,6 @@
 usr/bin/radclient
 usr/bin/radcrypt
 usr/bin/radeapclient
-usr/bin/radlast
 usr/bin/radsecret
 usr/bin/radsniff
 usr/bin/radsqlrelay
diff --git a/debian/rules b/debian/rules
index 6410223..501f673 100755
--- a/debian/rules
+++ b/debian/rules
@@ -74,8 +74,7 @@ override_dh_auto_configure:
 		--without-rlm_eap_ikev2 \
 		--without-rlm_sql_oracle \
 		--without-rlm_sql_unixodbc \
-		--with-systemd \
-		--with-radlast
+		--with-systemd
 
 %:
 	dh $@