ensure-vmtools-in-vmdk-header : lp:~jchittum/livecd-rootfs : Git : Code : livecd-rootfs

Get this branch:: git clone -b ensure-vmtools-in-vmdk-header https://git.launchpad.net/~jchittum/livecd-rootfs

Only John Chittum can upload to this branch. If you are John Chittum please log in for upload directions.

Branch merges

Merged into livecd-rootfs:ubuntu/master at revision df38b9ba752c009c81c885db88c6168eb17d8a44

Robert C Jennings (community): Approve on 2020-10-28

Ubuntu Core Development Team: Pending requested 2020-10-16

Branch information

Name:: ensure-vmtools-in-vmdk-header

Repository:: lp:~jchittum/livecd-rootfs

Recent commits

4f1df73... by John Chittum on 2020-10-26

Debug logging information

Added context lines for debugging lines.

201addb... by John Chittum on 2020-10-19

Remove sed and move size check

There was a question on if the comment removals in the `sed` were
required. The comments (`#`) are created by vmdk-stream-converter and
seem to cause no issues. `ddb.comment` is no longer being written by the
tool anymore. Moved the check earlier to ensure the new header isn't too
large before running truncate (otherwise it may be too long, and we
remove bits we want)

4f5eacb... by John Chittum on 2020-10-19

Fixup Debian Changlog

Rebase, fixedup changelog, opened new release

24ee4b8... by John Chittum on 2020-10-16

vmtools version in vmdk header (LP: #1893898)

LP: #1893898 describes missing vmtools version from the vmdk headers.
The version should be added as ddb.toolsVersion = "2147483647" however
the sed was no longer replacing a ddb.comment field with the tools
version. Rather than subbing ddb.comment with toolsVersion, this commit
deletes ddb.comment (which the comment mentions could cause errors),
and adds the correct value. There was no visibility into the descriptor
during hook creation, so debug statements were added. This allows us to
quickly verify in the logs that bad statements are removed (the possibly
offending commetns), as well as ensuring that the toolsVersion is added

81eba8d... by Łukasz Zemczak on 2020-10-19