Merge lp:~jbowtie/bzr/fix-555439 into lp:bzr
| Status: | Merged |
|---|---|
| Approved by: | Martin Pool on 2010-04-29 |
| Approved revision: | 5186 |
| Merged at revision: | 5208 |
| Proposed branch: | lp:~jbowtie/bzr/fix-555439 |
| Merge into: | lp:bzr |
| Diff against target: |
57 lines (+22/-16) 2 files modified
bzrlib/builtins.py (+1/-0) bzrlib/help_topics/__init__.py (+21/-16) |
| To merge this branch: | bzr merge lp:~jbowtie/bzr/fix-555439 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aaron Bentley (community) | Approve on 2010-04-30 | ||
| Martin Pool | 2010-04-28 | Approve on 2010-04-29 | |
|
Review via email:
|
|||
Commit Message
(jbowtie) document additional bzr environment variables
| Aaron Bentley (abentley) wrote : | # |
I think we should use consistent quotation marks within the help text. Have we started using curly quotes? If so, we should at least use them consistently in this string.
| Martin Pool (mbp) wrote : | # |
On 30 April 2010 10:19, Aaron Bentley <email address hidden> wrote:
> Review: Needs Fixing
> I think we should use consistent quotation marks within the help text.
agree.
> Have we started using curly quotes? If so, we should at least use them consistently in this string.
I didn't spot that. I don't think using curly quotes in help text is
worth the unicode hassles.
--
Martin <http://
| John C Barstow (jbowtie) wrote : | # |
> I think we should use consistent quotation marks within the help text. Have
> we started using curly quotes? If so, we should at least use them
> consistently in this string.
Sorry, I didn't spot that either; I cut and paste that particular string.
- 5187. By John C Barstow on 2010-04-30
-
Fix use of quotes in BZR_PROGRESS_BAR description
| John C Barstow (jbowtie) wrote : | # |
I've just pushed a fix for the quotes, turning them into single straight quotes like the surrounding material.
| Vincent Ladeuil (vila) wrote : | # |
Looks like all we need now is the contributor agreement: http://
Can you give it a look ?

it might be nice to give a mini-example but this is an improvement.
eventually it might be nice to not repeat ourselves and just have some kind of global definition of variables we care about. it may not be worth it if it's just once in the code and once in the docs.